Added flags to the AppDependency and simplified the AppModel #20070

aloubyansky · 2021-09-10T20:39:30Z

In addition to the runtime and/or deployment classpath origin, I need to be able to know more info about dependencies in the AppModel, such as:

whether a dependency is a direct one or transitive
whether it is an extension artifact or not
there could be more in the future

Instead of adding more and more fields and also potentially complicating the AppModel impl, I though using flags would be a better alternative.

This PR includes the following changes:

Added flags to the AppDependency to indicate whether a dependency i…s a direct one, an extension, belongs to the runtime and/or deployment CP
Simplified the AppModel by mering all the dependencies into a single list
Simplified Gradle's QuarkusModel impl and initialization

Also fixes #19497

aloubyansky · 2021-09-10T20:41:35Z

@stuartwdouglas would you mind reviewing at least the AppModel-related changes? I think it should also be more efficient from the [de]serialization perspective and initialization.

quarkus-bot · 2021-09-11T00:48:16Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `11bad4a`

Status	Name	Step	Failures	Logs	Raw logs
✖	Gradle Tests - JDK 11	`Build`	Failures	Logs	Raw logs
✖	Gradle Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs
✖	Native Tests - Data1	`Build`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 #

- Failing: integration-tests/gradle

📦 integration-tests/gradle

✖ io.quarkus.gradle.ImplementationFilesQuarkusBuildTest.test line 28 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting path:

✖ io.quarkus.gradle.devmode.ImplementationFilesDevModeTest.main line 21 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:166)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle

📦 integration-tests/gradle

✖ io.quarkus.gradle.ImplementationFilesQuarkusBuildTest.test line 28 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting path:

✖ io.quarkus.gradle.devmode.ImplementationFilesDevModeTest.main line 21 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:166)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

⚙️ Native Tests - Data1 #

- Failing: integration-tests/hibernate-orm-tenancy/connection-resolver

📦 integration-tests/hibernate-orm-tenancy/connection-resolver

✖ io.quarkus.it.hibernate.multitenancy.inventory.HibernateNamedPersistenceUnitTestInGraalITCase.testGetPlanesDefaultTenant - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code is <200> but was <500>.

✖ io.quarkus.it.hibernate.multitenancy.inventory.HibernateNamedPersistenceUnitTestInGraalITCase.testGetPlanesTenantMycompany - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Expected status code is <200> but was <500>.

quarkus-bot · 2021-09-12T01:05:26Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `2971e93`

Status	Name	Step	Failures	Logs	Raw logs
✖	MicroProfile TCKs Tests	`Verify`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ MicroProfile TCKs Tests #

- Failing: tcks/microprofile-config

📦 tcks/microprofile-config

✖ org.eclipse.microprofile.config.tck.ConfigPropertiesTest.testConfigPropertiesDefaultOnBean line 172 - More details - Source on GitHub

java.lang.NullPointerException
	at org.eclipse.microprofile.config.tck.ConfigPropertiesTest.testConfigPropertiesDefaultOnBean(ConfigPropertiesTest.java:172)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

✖ org.eclipse.microprofile.config.tck.ConfigPropertiesTest.testConfigPropertiesNoPrefixOnBean line 149 - More details - Source on GitHub

java.lang.NullPointerException
	at org.eclipse.microprofile.config.tck.ConfigPropertiesTest.testConfigPropertiesNoPrefixOnBean(ConfigPropertiesTest.java:149)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

✖ org.eclipse.microprofile.config.tck.ConfigPropertiesTest.testConfigPropertiesNoPrefixOnBeanThenSupplyPrefix line 156 - More details - Source on GitHub

java.lang.NullPointerException
	at org.eclipse.microprofile.config.tck.ConfigPropertiesTest.testConfigPropertiesNoPrefixOnBeanThenSupplyPrefix(ConfigPropertiesTest.java:156)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

✖ org.eclipse.microprofile.config.tck.ConfigPropertiesTest.testConfigPropertiesPlainInjection line 106 - More details - Source on GitHub

java.lang.NullPointerException
	at org.eclipse.microprofile.config.tck.ConfigPropertiesTest.testConfigPropertiesPlainInjection(ConfigPropertiesTest.java:106)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

✖ org.eclipse.microprofile.config.tck.ConfigPropertiesTest.testConfigPropertiesWithPrefix line 115 - More details - Source on GitHub

java.lang.NullPointerException
	at org.eclipse.microprofile.config.tck.ConfigPropertiesTest.testConfigPropertiesWithPrefix(ConfigPropertiesTest.java:115)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

✖ org.eclipse.microprofile.config.tck.ConfigPropertiesTest.testConfigPropertiesWithoutPrefix line 132 - More details - Source on GitHub

java.lang.NullPointerException
	at org.eclipse.microprofile.config.tck.ConfigPropertiesTest.testConfigPropertiesWithoutPrefix(ConfigPropertiesTest.java:132)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

✖ org.eclipse.microprofile.config.tck.ConfigPropertiesTest.testNoConfigPropertiesAnnotationInjection line 165 - More details - Source on GitHub

java.lang.NullPointerException
	at org.eclipse.microprofile.config.tck.ConfigPropertiesTest.testNoConfigPropertiesAnnotationInjection(ConfigPropertiesTest.java:165)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

…s a direct one, an extension, belongs to the runtime and/or deployment CP * Simplified the AppModel by mering all the dependencies into a single list

quarkus-bot · 2021-09-12T08:13:21Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `0c85b27`

Status	Name	Step	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 16

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/hibernate-orm/deployment 
! Skipped: docs extensions/hibernate-envers/deployment extensions/hibernate-reactive/deployment and 83 more

📦 extensions/hibernate-orm/deployment

✖ io.quarkus.hibernate.orm.transaction.GetTransactionLifecycleTest. - More details - Source on GitHub

java.lang.AssertionError: 

Expecting empty but was: ["Netty DefaultChannelId initialization (with io.netty.machineId system property set to 6f:02:f2:02:e1:65:ba:54) took more than a second"]

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/amazon-lambda/deployment 
! Skipped: docs extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment and 6 more

📦 extensions/amazon-lambda/deployment

✖ io.quarkus.amazon.lambda.deployment.testing.LambdaDevServicesContinuousTestingTestCase.testLambda line 41 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <0> but was: <1>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

quarkus-bot · 2021-09-12T15:03:44Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `0c85b27`

Status	Name	Step	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11 Windows	`Build`	⚠️ Check →	Logs	Raw logs
✔️	JVM Tests - JDK 16

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/hibernate-orm/deployment 
! Skipped: docs extensions/hibernate-envers/deployment extensions/hibernate-reactive/deployment and 83 more

📦 extensions/hibernate-orm/deployment

✖ io.quarkus.hibernate.orm.transaction.GetTransactionLifecycleTest. - More details - Source on GitHub

java.lang.AssertionError: 

Expecting empty but was: ["Netty DefaultChannelId initialization (with io.netty.machineId system property set to 31:e6:4f:69:6b:f6:c8:6d) took more than a second"]

glefloch

LGTM. This is nice, the model will be easier to use.

quarkus-bot · 2021-09-12T22:00:13Z

Failing Jobs - Building `0c85b27`

Status	Name	Step	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 11
⌛	JVM Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 16

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 Windows #

- Failing: extensions/amazon-lambda/deployment 
! Skipped: docs extensions/amazon-lambda-http/deployment extensions/amazon-lambda-rest/deployment and 6 more

📦 extensions/amazon-lambda/deployment

✖ io.quarkus.amazon.lambda.deployment.testing.LambdaDevServicesContinuousTestingTestCase.testLambda line 41 - More details - Source on GitHub

org.opentest4j.AssertionFailedError: expected: <0> but was: <1>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)

quarkus-bot bot added area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/gradle Gradle labels Sep 10, 2021

aloubyansky requested review from glefloch and stuartwdouglas September 10, 2021 20:40

aloubyansky force-pushed the app-dependency-flags branch from 11bad4a to 2971e93 Compare September 11, 2021 20:56

* Added flags to the AppDependency to indicate whether a dependency i…

0c85b27

…s a direct one, an extension, belongs to the runtime and/or deployment CP * Simplified the AppModel by mering all the dependencies into a single list

aloubyansky force-pushed the app-dependency-flags branch from 2971e93 to 0c85b27 Compare September 12, 2021 04:24

glefloch approved these changes Sep 12, 2021

View reviewed changes

aloubyansky merged commit 4fed7a4 into quarkusio:main Sep 14, 2021

quarkus-bot bot added this to the 2.3 - main milestone Sep 14, 2021

Sgitario mentioned this pull request Sep 21, 2021

Fix forced dependencies when using 999-SNAPSHOT (future 2.3) quarkus-qe/quarkus-test-framework#274

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added flags to the AppDependency and simplified the AppModel #20070

Added flags to the AppDependency and simplified the AppModel #20070

aloubyansky commented Sep 10, 2021

aloubyansky commented Sep 10, 2021

quarkus-bot bot commented Sep 11, 2021 •

edited

Loading

Failing Jobs - Building `11bad4a`

Failures

⚙️ Gradle Tests - JDK 11 #

📦 integration-tests/gradle

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

⚙️ Native Tests - Data1 #

📦 integration-tests/hibernate-orm-tenancy/connection-resolver

quarkus-bot bot commented Sep 12, 2021 •

edited

Loading

Failing Jobs - Building `2971e93`

Failures

⚙️ MicroProfile TCKs Tests #

📦 tcks/microprofile-config

quarkus-bot bot commented Sep 12, 2021 •

edited

Loading

Failing Jobs - Building `0c85b27`

Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/hibernate-orm/deployment

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/amazon-lambda/deployment

quarkus-bot bot commented Sep 12, 2021 •

edited

Loading

Failing Jobs - Building `0c85b27`

Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/hibernate-orm/deployment

glefloch left a comment

quarkus-bot bot commented Sep 12, 2021

Added flags to the AppDependency and simplified the AppModel #20070

Added flags to the AppDependency and simplified the AppModel #20070

Conversation

aloubyansky commented Sep 10, 2021

aloubyansky commented Sep 10, 2021

quarkus-bot bot commented Sep 11, 2021 • edited Loading

Failing Jobs - Building 11bad4a

Failures

⚙️ Gradle Tests - JDK 11 #

📦 integration-tests/gradle

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

⚙️ Native Tests - Data1 #

📦 integration-tests/hibernate-orm-tenancy/connection-resolver

quarkus-bot bot commented Sep 12, 2021 • edited Loading

Failing Jobs - Building 2971e93

Failures

⚙️ MicroProfile TCKs Tests #

📦 tcks/microprofile-config

quarkus-bot bot commented Sep 12, 2021 • edited Loading

Failing Jobs - Building 0c85b27

Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/hibernate-orm/deployment

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/amazon-lambda/deployment

quarkus-bot bot commented Sep 12, 2021 • edited Loading

Failing Jobs - Building 0c85b27

Failures

⚙️ JVM Tests - JDK 11 #

📦 extensions/hibernate-orm/deployment

glefloch left a comment

Choose a reason for hiding this comment

quarkus-bot bot commented Sep 12, 2021

Failing Jobs - Building 0c85b27

Failures

⚙️ JVM Tests - JDK 11 Windows #

📦 extensions/amazon-lambda/deployment

quarkus-bot bot commented Sep 11, 2021 •

edited

Loading

Failing Jobs - Building `11bad4a`

quarkus-bot bot commented Sep 12, 2021 •

edited

Loading

Failing Jobs - Building `2971e93`

quarkus-bot bot commented Sep 12, 2021 •

edited

Loading

Failing Jobs - Building `0c85b27`

quarkus-bot bot commented Sep 12, 2021 •

edited

Loading

Failing Jobs - Building `0c85b27`

Failing Jobs - Building `0c85b27`