Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make MongoTestResource configurable #20227

Merged
merged 1 commit into from
Sep 17, 2021
Merged

Make MongoTestResource configurable #20227

merged 1 commit into from
Sep 17, 2021

Conversation

jsmrcka
Copy link
Contributor

@jsmrcka jsmrcka commented Sep 17, 2021

Makes MongoTestResource's port configurable.
Replaces the use of a custom MongoTestResource in the
mongodb-rest-data-panache integration tests.

Fixes #20211.

@jsmrcka
Make MongoTestResource configurable
e0ed06b 
Makes `MongoTestResource`'s port configurable.
Replaces the use of a custom `MongoTestResource` in the
`mongodb-rest-data-panache` integration tests.

Fixes quarkusio#20211.
@jsmrcka jsmrcka mentioned this pull request Sep 17, 2021
Closed
geoand
geoand approved these changes Sep 17, 2021
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks!

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 17, 2021
@geoand geoand merged commit bf2739f into quarkusio:main Sep 17, 2021
@quarkus-bot quarkus-bot bot added this to the 2.3 - main milestone Sep 17, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Sep 17, 2021
@jsmrcka jsmrcka deleted the gh#20211 branch September 17, 2021 14:57
@jsmrcka jsmrcka mentioned this pull request Sep 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

Assignees
No one assigned
Labels
area/testing
Projects
None yet
Milestone
2.3.0.CR1
Development

Successfully merging this pull request may close these issues.

mongodb-rest-data-panache integration tests use custom MongoTestResource
2 participants
@jsmrcka @geoand