Add support for @ResponseStatus and @ResponseHeader #20311

geoand · 2021-09-21T16:28:46Z

Closes: #20100

I took the tests from #20242 where @Yelzhasdev made a first attempt to implement the feature.

quarkus-bot · 2021-09-21T19:02:38Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `ba2eeb8`

Status	Name	Step	Failures	Logs	Raw logs
✖	Gradle Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle

📦 integration-tests/gradle

✖ io.quarkus.gradle.devmode.MultiModuleIncludedBuildTest.main line 24 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

stuartwdouglas · 2021-09-22T00:13:24Z

...src/main/java/org/jboss/resteasy/reactive/server/core/startup/RuntimeResourceDeployment.java

@@ -432,6 +437,45 @@ public RuntimeResource buildResourceMethod(ResourceClass clazz,
                pathParameterIndexes, score, sseElementType, clazz.resourceExceptionMapper());
    }

+    private void addResponseHandler(ServerResourceMethod method, List<ServerRestHandler> handlers) {


Why do we need the new ResponseHandler.ResponseBuilderCustomizer and PublisherResponseHandler.StreamingResponseCustomizer integration classes?

Couldn't we just register a handler in HandlerChainCustomizer.Phase#AFTER_RESPONSE_CREATED and use it to update the response?

2 reasons:

we don't want to update the response if it is created by the user - a Response returned by the user always takes precedence over the annotations.

In the case of streaming, there is no such phase. The streaming handler is essentially the last handler to be executed.

For 1 we could add an extra check and forgo the use of the customizer, but it would also mean that the Response would be created again - so slightly more overhead.

geoand · 2021-09-22T09:32:36Z

I am also wondering if using Response or RestResponse along with these annotations should be a build time error... Currently the annotations are silently ignored.

geoand · 2021-09-29T07:29:28Z

Fixed conflict

quarkus-bot · 2021-09-29T09:50:34Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `f8b7d93`

Status	Name	Step	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 11
✖	JVM Tests - JDK 17	`Build`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/grpc/deployment 
! Skipped: docs integration-tests/devmode integration-tests/grpc-health and 9 more

📦 extensions/grpc/deployment

✖ io.quarkus.grpc.devconsole.DevConsoleUnaryMethodTest.websocketTest line 57 - More details - Source on GitHub

java.lang.AssertionError: 

Expected size: 2 but was: 1 in:

geoand · 2021-10-12T07:11:48Z

@stuartwdouglas @FroMage what is your take on this one?
If we want it, I can rebase to fix the conflicts

geoand · 2021-10-13T12:28:56Z

I rebased the PR.

I think this makes sense to have as it also affects Kotlin users who want to use Flow as the return type (see #20100 (comment))

quarkus-bot · 2021-10-13T14:59:16Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `9b1b0a2`

Status	Name	Step	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 11
✖	JVM Tests - JDK 17	`Build`	Failures	Logs	Raw logs

Failures

⚙️ JVM Tests - JDK 17 #

- Failing: extensions/hibernate-search-orm-elasticsearch/deployment 
! Skipped: docs extensions/hibernate-search-orm-elasticsearch-aws/deployment integration-tests/hibernate-search-orm-elasticsearch and 1 more

📦 extensions/hibernate-search-orm-elasticsearch/deployment

✖ Failed to execute goal io.fabric8:docker-maven-plugin:0.37.0:start (docker-start) on project quarkus-hibernate-search-orm-elasticsearch-deployment: I/O Error

...teasy-reactive/common/runtime/src/main/java/org/jboss/resteasy/reactive/ResponseHeaders.java

Closes: quarkusio#20100 Co-authored-by: Yelzhas Suleimenov <[email protected]>

quarkus-bot · 2021-10-14T08:58:04Z

Failing Jobs - Building `d6aa606`

Status	Name	Step	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 17

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/kafka-sasl-elytron

📦 integration-tests/kafka-sasl-elytron

✖ io.quarkus.it.kafka.KafkaSaslTest.test - More details - Source on GitHub

java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
	at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:573)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestClassConstructor(QuarkusTestExtension.java:646)

geoand · 2021-10-14T09:00:47Z

The failure is completely unrelated

geoand requested review from FroMage and stuartwdouglas September 21, 2021 16:28

geoand mentioned this pull request Sep 21, 2021

Add the ability to set HTTP headers and Response status when returning Reactive Types from RESTEasy Reactive #20100

Closed

quarkus-bot bot added the area/rest label Sep 21, 2021

geoand force-pushed the #20100 branch from 060628d to ba2eeb8 Compare September 21, 2021 16:44

quarkus-bot bot added the area/documentation label Sep 21, 2021

stuartwdouglas reviewed Sep 22, 2021

View reviewed changes

geoand force-pushed the #20100 branch from ba2eeb8 to f8b7d93 Compare September 29, 2021 07:29

geoand force-pushed the #20100 branch from f8b7d93 to 9b1b0a2 Compare October 13, 2021 12:27

stuartwdouglas reviewed Oct 13, 2021

View reviewed changes

...teasy-reactive/common/runtime/src/main/java/org/jboss/resteasy/reactive/ResponseHeaders.java Outdated Show resolved Hide resolved

geoand force-pushed the #20100 branch from 9b1b0a2 to 097bc47 Compare October 14, 2021 05:57

stuartwdouglas approved these changes Oct 14, 2021

View reviewed changes

geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 14, 2021

Add support for @ResponseStatus and @ResponseHeader

d6aa606

Closes: quarkusio#20100 Co-authored-by: Yelzhas Suleimenov <[email protected]>

geoand force-pushed the #20100 branch from 097bc47 to d6aa606 Compare October 14, 2021 06:34

geoand merged commit ced07cc into quarkusio:main Oct 14, 2021

quarkus-bot bot added this to the 2.5 - main milestone Oct 14, 2021

quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 14, 2021

geoand deleted the #20100 branch October 14, 2021 09:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for @ResponseStatus and @ResponseHeader #20311

Add support for @ResponseStatus and @ResponseHeader #20311

geoand commented Sep 21, 2021 •

edited

Loading

quarkus-bot bot commented Sep 21, 2021 •

edited

Loading

Failing Jobs - Building `ba2eeb8`

Failures

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

stuartwdouglas Sep 22, 2021

geoand Sep 22, 2021

geoand Sep 22, 2021

geoand commented Sep 22, 2021

geoand commented Sep 29, 2021

quarkus-bot bot commented Sep 29, 2021 •

edited

Loading

Failing Jobs - Building `f8b7d93`

Failures

⚙️ JVM Tests - JDK 17 #

📦 extensions/grpc/deployment

geoand commented Oct 12, 2021

geoand commented Oct 13, 2021 •

edited

Loading

quarkus-bot bot commented Oct 13, 2021 •

edited

Loading

Failing Jobs - Building `9b1b0a2`

Failures

⚙️ JVM Tests - JDK 17 #

📦 extensions/hibernate-search-orm-elasticsearch/deployment

quarkus-bot bot commented Oct 14, 2021

geoand commented Oct 14, 2021

Add support for @ResponseStatus and @ResponseHeader #20311

Add support for @ResponseStatus and @ResponseHeader #20311

Conversation

geoand commented Sep 21, 2021 • edited Loading

quarkus-bot bot commented Sep 21, 2021 • edited Loading

Failing Jobs - Building ba2eeb8

Failures

⚙️ Gradle Tests - JDK 11 Windows #

📦 integration-tests/gradle

stuartwdouglas Sep 22, 2021

Choose a reason for hiding this comment

geoand Sep 22, 2021

Choose a reason for hiding this comment

geoand Sep 22, 2021

Choose a reason for hiding this comment

geoand commented Sep 22, 2021

geoand commented Sep 29, 2021

quarkus-bot bot commented Sep 29, 2021 • edited Loading

Failing Jobs - Building f8b7d93

Failures

⚙️ JVM Tests - JDK 17 #

📦 extensions/grpc/deployment

geoand commented Oct 12, 2021

geoand commented Oct 13, 2021 • edited Loading

quarkus-bot bot commented Oct 13, 2021 • edited Loading

Failing Jobs - Building 9b1b0a2

Failures

⚙️ JVM Tests - JDK 17 #

📦 extensions/hibernate-search-orm-elasticsearch/deployment

quarkus-bot bot commented Oct 14, 2021

Failing Jobs - Building d6aa606

Failures

⚙️ JVM Tests - JDK 11 #

📦 integration-tests/kafka-sasl-elytron

geoand commented Oct 14, 2021

geoand commented Sep 21, 2021 •

edited

Loading

quarkus-bot bot commented Sep 21, 2021 •

edited

Loading

Failing Jobs - Building `ba2eeb8`

quarkus-bot bot commented Sep 29, 2021 •

edited

Loading

Failing Jobs - Building `f8b7d93`

geoand commented Oct 13, 2021 •

edited

Loading

quarkus-bot bot commented Oct 13, 2021 •

edited

Loading

Failing Jobs - Building `9b1b0a2`

Failing Jobs - Building `d6aa606`