Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for multiple sql load scripts #20488

Merged
merged 2 commits into from
Oct 4, 2021
Merged

Add support for multiple sql load scripts #20488

merged 2 commits into from
Oct 4, 2021

Conversation

mschnitzler
Copy link
Contributor

This PR fixes the issue #20177.
The property "quarkus.hibernate-orm.sql-load-script" can now take a comma separated list of SQL load scripts.

@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot quarkus-bot bot added area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE labels Sep 30, 2021
@mschnitzler mschnitzler changed the title add support for multiple sql load scripts Add support for multiple sql load scripts Sep 30, 2021
@mschnitzler mschnitzler closed this Oct 1, 2021
@quarkus-bot quarkus-bot bot added the triage/invalid This doesn't seem right label Oct 1, 2021
@mschnitzler mschnitzler reopened this Oct 1, 2021
@quarkus-bot quarkus-bot bot removed the triage/invalid This doesn't seem right label Oct 1, 2021
@geoand geoand requested a review from yrodiere October 1, 2021 08:14
yrodiere
yrodiere reviewed Oct 1, 2021
View reviewed changes
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to fix that, thanks!

I have a few comments, but nothing blocking. Let me know what you think?

...-orm/deployment/src/main/java/io/quarkus/hibernate/orm/deployment/HibernateOrmProcessor.java Outdated Show resolved Hide resolved
...-orm/deployment/src/main/java/io/quarkus/hibernate/orm/deployment/HibernateOrmProcessor.java Outdated Show resolved Hide resolved
@quarkus-bot quarkus-bot bot added the area/hibernate-reactive Hibernate Reactive label Oct 1, 2021
yrodiere
yrodiere approved these changes Oct 1, 2021
View reviewed changes
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks.

@yrodiere yrodiere added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 1, 2021
@geoand geoand merged commit e0d19f3 into quarkusio:main Oct 4, 2021
@quarkus-bot quarkus-bot bot added this to the 2.4 - main milestone Oct 4, 2021
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Oct 4, 2021
@mschnitzler mschnitzler deleted the 20177-multiple-sql-load-scripts branch October 4, 2021 06:55
@yrodiere yrodiere linked an issue Oct 28, 2021 that may be closed by this pull request
Multiple files in sql-load-script #20177
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrodiere yrodiere yrodiere approved these changes

Assignees
No one assigned
Labels
area/hibernate-orm Hibernate ORM area/hibernate-reactive Hibernate Reactive area/persistence OBSOLETE, DO NOT USE
Projects
None yet
Milestone
2.4.0.CR1
Development

Successfully merging this pull request may close these issues.

Multiple files in sql-load-script
3 participants
@mschnitzler @yrodiere @geoand