Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qute type-safe validation improvements #20669

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Oct 11, 2021

- validate expressions that start with a namespace coming from a TemplateData annotation
- validate nested "inject:" namespace expressions, ie. used as method
params
- resolves quarkusio#20621
- also introduce io.quarkus.qute.TemplateData.SIMPLENAME and fix
TemplateData javadoc
@quarkus-bot quarkus-bot bot added the area/qute The template engine label Oct 11, 2021
@mkouba
Copy link
Contributor Author

mkouba commented Oct 11, 2021

This is a follow-up of #20669.

@mkouba
Copy link
Contributor Author

mkouba commented Oct 11, 2021

@gastaldi sanity check pls ;-)

Copy link
Contributor

@gastaldi gastaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkouba mkouba merged commit fe1e3b7 into quarkusio:main Oct 12, 2021
@quarkus-bot quarkus-bot bot added this to the 2.5 - main milestone Oct 12, 2021
@quarkus-bot
Copy link

quarkus-bot bot commented Oct 12, 2021

Milestone is already set for some of the items:

We haven't automatically updated the milestones for these items.

This message is automatically generated by a bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/qute The template engine
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Qute - validate expressions that start with a namespace coming from a TemplateData annotation
3 participants