Ensure that async console logging does not prevent failed startup errors #20695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if it might help, but AsyncHandler has a method (inherited from parent) #flush() |
|
That is not enough unfortunately. The issue is that the thread that takes records off the queue is a daemon thread and there is no way to interact with its lifecycle. As I said above, this PR is a hack for the current state of things and a proper would involve updating |
gastaldi
reviewed
Oct 13, 2021
core/runtime/src/main/java/io/quarkus/runtime/logging/AsyncLogging.java
Outdated
Show resolved
Hide resolved
gastaldi
approved these changes
Oct 13, 2021
geoand
added
the
triage/waiting-for-ci
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a hack, the proper solution would probably be to introduce some state management into the
AsyncHandlerwhich would allow us to wait for it to drain it's queue and finish publishing all the records to its child handlers.Nonetheless, this is way better than the current situation where the console logging is completely missing and users don't know whats wrong.
Fixes: #20660