Support for JPA entity listeners, including in native mode #20708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quarkus-bot
bot
added
area/documentation
area/hibernate-orm
gsmet
approved these changes
Oct 13, 2021
...rm/deployment/src/main/java/io/quarkus/hibernate/orm/deployment/HibernateOrmAnnotations.java
Outdated
Show resolved
Hide resolved
yrodiere
force-pushed
the
i6948-entitylistener-cdi
branch
from
f68a237 to
5407188
Compare
|
Thanks @gsmet , I addressed your comments. Let's wait for hibernate/hibernate-orm#4296 to get merged and released. |
yrodiere
force-pushed
the
i6948-entitylistener-cdi
branch
from
7a14c80 to
487d19b
Compare
|
I forgot to address and test |
yrodiere
force-pushed
the
i6948-entitylistener-cdi
branch
from
487d19b to
2abb843
Compare
We've never needed that for attribute converters, since reflection for those is performed when building Metadata. We don't need it anymore for listeners once HHH-14869 gets fixed.
yrodiere
force-pushed
the
i6948-entitylistener-cdi
branch
from
2abb843 to
b9893a5
Compare
yrodiere
added
the
triage/waiting-for-ci
|
This workflow status is outdated as a new workflow run has been triggered. |
Failing Jobs - Building b9893a5
Failures⚙️ Native Tests - Windows - hibernate-validator #- Failing: integration-tests/hibernate-validator
📦 integration-tests/hibernate-validator✖ |
|
The failure is on a native build of integration tests for Hibernate Validator on Windows. It's unrelated to this PR. Merging! |
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12740, #6948 (the two top issues of the Hibernate ORM extension at the moment, by number of votes).
Creating this PR as draft, since we will need hibernate/hibernate-orm#4296 to be merged and released upstream before we can merge this PR.
Alternatively, we could just drop the last commit, use reflection at runtime in the native application, and it would work without any change in Hibernate ORM. But that would have to be temporary; personally I'd rather wait until the next Hibernate ORM release, which shouldn't take too long anyway.