Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security annotations don't work with CompletionStage #20997

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

stuartwdouglas
Copy link
Member

Fixes #20979

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 26, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building ab6cb23

Status Name Step Failures Logs Raw logs
MicroProfile TCKs Tests Verify Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ MicroProfile TCKs Tests #

- Failing: tcks/microprofile-fault-tolerance 

📦 tcks/microprofile-fault-tolerance

org.eclipse.microprofile.fault.tolerance.tck.TimeoutUninterruptableTest.testTimeoutAsyncBulkhead line 190 - More details - Source on GitHub

java.lang.AssertionError: Unexpected exception thrown from Future
	at org.testng.Assert.fail(Assert.java:85)
	at org.eclipse.microprofile.fault.tolerance.tck.util.Exceptions.expect(Exceptions.java:98)

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 26, 2021

Failing Jobs - Building 5990962

Status Name Step Failures Logs Raw logs
Native Tests - Messaging2 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Native Tests - Messaging2 #

- Failing: integration-tests/reactive-messaging-rabbitmq 

📦 integration-tests/reactive-messaging-rabbitmq

io.quarkus.it.rabbitmq.RabbitMQConnectorIT.test - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a io.quarkus.it.rabbitmq.RabbitMQConnectorTest expected: <6> but was: <0> within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)

@geoand
Copy link
Contributor

geoand commented Oct 26, 2021

@cescoffier the RabbitMQConnectorIT seems to be failing often in CI.

There doesn't seem to be anything obviously wrong with the test, so maybe there is an issue in the SR RM RabbitMQ module?

@cescoffier
Copy link
Member

@geoand The rabbit MQ connector is very new and probably not very stable yet. However, the test suite in reactive messaging seems to be ok. We should ping the contributor.

@geoand
Copy link
Contributor

geoand commented Oct 26, 2021

@kdubb ^

@kdubb
Copy link
Contributor

kdubb commented Oct 26, 2021

The Quarkus SR RM RabbitMQ module does nothing except add the SR RM RMQ dependency. I am having no trouble running the tests locally but I am usually using the 3.11.0-SNAPSHOT of SR RM RMQ; I will try local testing with the 3.10.2 version and see if that causes issues.

Also, I was seeing intermittent failing of internal ITs that use Dev Services when I was running the module, as if the external docker service wasn't getting started in a timely fashion. In my last two rebases of the PR that issue seemed to have gone away. Is that a previously known issue? If so, how is that generally remedied. (You can see the evidence of this in the PR #20659 test history).

@michalszynkiewicz michalszynkiewicz merged commit 8205e5e into quarkusio:main Oct 26, 2021
@quarkus-bot quarkus-bot bot added this to the 2.5 - main milestone Oct 26, 2021
@gsmet gsmet modified the milestones: 2.5 - main, 2.4.1.Final Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@RolesAllowed causes CompletionStage to be serialized as itself
6 participants