Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix count / delete operations when using named query #21023

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Fix count / delete operations when using named query #21023

merged 1 commit into from
Nov 2, 2021

Conversation

gilvansfilho
Copy link
Contributor

Fix to issue #20758

@gilvansfilho
Copy link
Contributor Author

@loicmathieu I tested this locally using hibernate-orm-panache-quickstart and is working well with named query with and without parameters

I tried to write some unit tests for this but I got contextNotActiveException so I not commited this.

@gilvansfilho gilvansfilho changed the title Fic count operations when using named query Fix count operations when using named query Oct 27, 2021
@gilvansfilho gilvansfilho changed the title Fix count operations when using named query Fix count / delete operations when using named query Oct 27, 2021
Copy link
Contributor

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must add a test inside the integration test.
The guide also should be updated, at least with a note saying that named queries can also be used with the count methods.

@gilvansfilho
Copy link
Contributor Author

@loicmathieu I think all is done. Could you check?

Copy link
Contributor

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks indead way better :)

Thanks for providing so much tests.
The same should also be done for Hibernate Reactive, I can take care of it if you can't.
Can you please mark your PR ready so I can launch the CI on it after taking care of the two minor feedback ?

@gilvansfilho
Copy link
Contributor Author

The same should also be done for Hibernate Reactive, I can take care of it if you can't.

I think I could. I don't know much about reactive so let's open new issue for this. So we can merge and close this.

Can you please mark your PR ready so I can launch the CI on it after taking care of the two minor feedback ?

Done.

@gilvansfilho gilvansfilho marked this pull request as ready for review October 29, 2021 11:56
@loicmathieu
Copy link
Contributor

I think I could. I don't know much about reactive so let's open new issue for this. So we can merge and close this.

Don't open a new issue if you will make the PR soon no need to, just provide the new PR next week and it'll be OK.
If you don't think you will have time soon, then better to open a PR not to forget it.

Copy link
Contributor

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing it, nice addition with a neat implementation ;)

@FroMage maybe you want to have a look ?

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 29, 2021

This workflow status is outdated as a new workflow run has been triggered.

🚫 This workflow run has been cancelled.

✖ This workflow run has failed but no jobs reported an error. Something weird happened, please check the workflow run page carefully: it might be an issue with the workflow configuration itself.

@gilvansfilho
Copy link
Contributor Author

Don't open a new issue if you will make the PR soon no need to, just provide the new PR next week and it'll be OK. If you don't think you will have time soon, then better to open a PR not to forget it.

@loicmathieu I don't be sure if I will have time for it next week, but I want to try this. Ok for you?

@quarkus-bot
Copy link

quarkus-bot bot commented Oct 29, 2021

Failing Jobs - Building d0c921c

Status Name Step Failures Logs Raw logs
Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.devmode.BasicKotlinApplicationModuleDevModeTest.main line 18 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

@gilvansfilho
Copy link
Contributor Author

@loicmathieu What about failed build step of Gradle Tests - JDK 11 Windows job? I runned this locally ./mvnw install -pl integrations-tests/gradle and works fine. Could I rerun on CI?

@loicmathieu loicmathieu added this to the 2.5 - main milestone Nov 2, 2021
@loicmathieu
Copy link
Contributor

The failure is in an un-related CI task and both JDK11 and JDK17 tests passed.
I'm merging it, thanks @gilvansfilho !

@loicmathieu loicmathieu merged commit 6c82713 into quarkusio:main Nov 2, 2021
@gilvansfilho gilvansfilho deleted the fix/20758 branch November 3, 2021 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants