-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix count / delete operations when using named query #21023
Conversation
@loicmathieu I tested this locally using hibernate-orm-panache-quickstart and is working well with named query with and without parameters I tried to write some unit tests for this but I got contextNotActiveException so I not commited this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You must add a test inside the integration test.
The guide also should be updated, at least with a note saying that named queries can also be used with the count methods.
...ime/src/main/java/io/quarkus/hibernate/orm/panache/common/runtime/AbstractJpaOperations.java
Outdated
Show resolved
Hide resolved
...ime/src/main/java/io/quarkus/hibernate/orm/panache/common/runtime/AbstractJpaOperations.java
Outdated
Show resolved
Hide resolved
@loicmathieu I think all is done. Could you check? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks indead way better :)
Thanks for providing so much tests.
The same should also be done for Hibernate Reactive, I can take care of it if you can't.
Can you please mark your PR ready so I can launch the CI on it after taking care of the two minor feedback ?
integration-tests/hibernate-orm-panache/src/main/java/io/quarkus/it/panache/TestEndpoint.java
Show resolved
Hide resolved
...ime/src/main/java/io/quarkus/hibernate/orm/panache/common/runtime/AbstractJpaOperations.java
Outdated
Show resolved
Hide resolved
I think I could. I don't know much about reactive so let's open new issue for this. So we can merge and close this.
Done. |
Don't open a new issue if you will make the PR soon no need to, just provide the new PR next week and it'll be OK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for doing it, nice addition with a neat implementation ;)
@FroMage maybe you want to have a look ?
This workflow status is outdated as a new workflow run has been triggered. 🚫 This workflow run has been cancelled. ✖ This workflow run has failed but no jobs reported an error. Something weird happened, please check the workflow run page carefully: it might be an issue with the workflow configuration itself. |
@loicmathieu I don't be sure if I will have time for it next week, but I want to try this. Ok for you? |
Failing Jobs - Building d0c921c
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 Windows #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
|
@loicmathieu What about failed build step of Gradle Tests - JDK 11 Windows job? I runned this locally |
The failure is in an un-related CI task and both JDK11 and JDK17 tests passed. |
Fix to issue #20758