-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix panache+kotlin named datasource issue #21079
Conversation
#21080 is related |
This seems so easy ! For my personal knowledge, can you explain a bit what happended ? Because I checked by adding a sysout that the method was correctly called during build time, so I suppose the fact that the method was not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I tested it with the reproducer and it works now! Thanks!
Just saw that you already cover this in #21080 :) |
The issue is that it was called at build time, it was not recorded to run
at runtime.
…On Fri, 29 Oct 2021, 6:11 pm Loïc Mathieu, ***@***.***> wrote:
This seems so easy !
For my personal knowledge, can you explain a bit what happended ? Because
I checked by adding a sysout that the method was correctly called during
build time, so I suppose the fact that the method was not open make the
recorder *replay* system at runtime not working ?
In this case, maybe something is missing so we can have an exception
thrown ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#21079 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACQG6YSHYUYTN3INDIAB6LUJJJLXANCNFSM5G6OR6WA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good catch!
Fixes #20882