Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panache+kotlin named datasource issue #21079

Merged
merged 1 commit into from
Oct 29, 2021
Merged

Conversation

stuartwdouglas
Copy link
Member

Fixes #20882

@stuartwdouglas
Copy link
Member Author

#21080 is related

@loicmathieu
Copy link
Contributor

This seems so easy !

For my personal knowledge, can you explain a bit what happended ? Because I checked by adding a sysout that the method was correctly called during build time, so I suppose the fact that the method was not open make the recorder replay system at runtime not working ?
In this case, maybe something is missing so we can have an exception thrown ?

Copy link
Contributor

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I tested it with the reproducer and it works now! Thanks!

@loicmathieu
Copy link
Contributor

@stuartwdouglas

In this case, maybe something is missing so we can have an exception thrown ?

Just saw that you already cover this in #21080 :)

@stuartwdouglas
Copy link
Member Author

stuartwdouglas commented Oct 29, 2021 via email

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good catch!

@geoand geoand merged commit b272148 into quarkusio:main Oct 29, 2021
@quarkus-bot quarkus-bot bot added this to the 2.5 - main milestone Oct 29, 2021
@gsmet gsmet modified the milestones: 2.5 - main, 2.4.1.Final Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panache entities not found when using multiple datasources in Quarkus 2.x versions
4 participants