-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added "User-Agent" header to requests made to the Lambda Runtime API #21458
Conversation
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
this feels like something we should have config for that the various http clients will be able to use? |
Hi @maxandersen, Maybe, I couldn't see any http client in this module, so I followed the style which was existing. |
I definitely agree |
I think having a configurable user agent for lambda would be a good first step. If we generalize it at some point we could use the more general one if not set. @msailes I'm not sure we have some config root for lambda yet though. My guess would be to add something to |
Just curious, why the user agent? Does the lambda event server want that information? |
Yes, it helps us understand which frameworks are used. |
rebase, squash and i'll spin off CI. Sorry this fell through the cracks. |
No problem |
Updated |
Can you please rebase the PR onto Thanks |
Done |
The value of the header will be in the format "quarkus/%s-%s" where the first position will be a description of the Java version and the second being the version of Quarkus.
The value of the header will be in the format "quarkus/%s-%s" where the first position will be a description of the Java version and the second being the version of Quarkus.
There were no existing tests for the class I changed, I'd be happy to write some tests if given guidance.
Thanks,