-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RestClientFallbackConfigSourceInterceptor#iterateNames() #21620
Fix RestClientFallbackConfigSourceInterceptor#iterateNames() #21620
Conversation
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 1b3bce3
Failures⚙️ Initial JDK 11 Build #- Failing: extensions/resteasy-classic/rest-client/config
! Skipped: devtools/bom-descriptor-json docs extensions/grpc/deployment and 109 more 📦 extensions/resteasy-classic/rest-client/config✖ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TomasHofman you need to run the formatter :)
1b3bce3
to
0608cdb
Compare
I force-pushed the formatter change. |
Should this be backported to |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 0608cdb
Failures⚙️ Initial JDK 11 Build #- Failing: extensions/resteasy-classic/rest-client/config
! Skipped: devtools/bom-descriptor-json docs extensions/grpc/deployment and 109 more 📦 extensions/resteasy-classic/rest-client/config✖ |
The fallback interceptor shouldn't do any conversions on properties that are prefixed with the "%profile." prefixes. The fact that the profile prefix is present means the property belongs to an inactive profile. The active profile property names should be already normalized by the ProfileConfigSourceInterceptor interceptor.
0608cdb
to
bb148be
Compare
@geoand I think this should be backported, it's a functional fix. Anything I should do regarding backport? Thanks for fixing the formatting :). |
You don't need to do anything, I'll add the proper label.
NP! |
The fallback interceptor shouldn't do any conversions on properties that are
prefixed with the "%profile." prefixes. The fact that the profile prefix
is present means the property belongs to an inactive profile. The active
profile property names should be already normalized by the
ProfileConfigSourceInterceptor interceptor.
This fixes #21533