Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RestClientFallbackConfigSourceInterceptor#iterateNames() #21620

Merged

Conversation

TomasHofman
Copy link
Contributor

The fallback interceptor shouldn't do any conversions on properties that are
prefixed with the "%profile." prefixes. The fact that the profile prefix
is present means the property belongs to an inactive profile. The active
profile property names should be already normalized by the
ProfileConfigSourceInterceptor interceptor.

This fixes #21533

@quarkus-bot
Copy link

quarkus-bot bot commented Nov 22, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 1b3bce3

Status Name Step Failures Logs Raw logs
Initial JDK 11 Build Build Failures Logs Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: extensions/resteasy-classic/rest-client/config 
! Skipped: devtools/bom-descriptor-json docs extensions/grpc/deployment and 109 more

📦 extensions/resteasy-classic/rest-client/config

Failed to execute goal net.revelc.code.formatter:formatter-maven-plugin:2.17.0:validate (default) on project quarkus-rest-client-config: File '/home/runner/work/quarkus/quarkus/extensions/resteasy-classic/rest-client/config/src/test/java/io/quarkus/restclient/config/RestClientFallbackConfigSourceInterceptorTest.java' has not been previously formatted. Please format file and commit before running validation!

Copy link
Member

@radcortez radcortez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomasHofman you need to run the formatter :)

@geoand geoand force-pushed the rest-client-fallback-interceptor-fix branch from 1b3bce3 to 0608cdb Compare November 23, 2021 08:09
@geoand
Copy link
Contributor

geoand commented Nov 23, 2021

I force-pushed the formatter change.

@geoand geoand requested a review from radcortez November 23, 2021 08:09
@geoand
Copy link
Contributor

geoand commented Nov 23, 2021

Should this be backported to 2.5?

@quarkus-bot
Copy link

quarkus-bot bot commented Nov 23, 2021

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 0608cdb

Status Name Step Failures Logs Raw logs
Initial JDK 11 Build Build Failures Logs Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: extensions/resteasy-classic/rest-client/config 
! Skipped: devtools/bom-descriptor-json docs extensions/grpc/deployment and 109 more

📦 extensions/resteasy-classic/rest-client/config

Failed to execute goal net.revelc.code.formatter:formatter-maven-plugin:2.17.0:validate (default) on project quarkus-rest-client-config: File '/home/runner/work/quarkus/quarkus/extensions/resteasy-classic/rest-client/config/src/test/java/io/quarkus/restclient/config/RestClientFallbackConfigSourceInterceptorTest.java' has not been previously formatted. Please format file and commit before running validation!

The fallback interceptor shouldn't do any conversions on properties that are
prefixed with the "%profile." prefixes. The fact that the profile prefix
is present means the property belongs to an inactive profile. The active
profile property names should be already normalized by the
ProfileConfigSourceInterceptor interceptor.
@geoand geoand force-pushed the rest-client-fallback-interceptor-fix branch from 0608cdb to bb148be Compare November 23, 2021 08:25
@TomasHofman
Copy link
Contributor Author

Should this be backported to 2.5?

@geoand I think this should be backported, it's a functional fix. Anything I should do regarding backport?

Thanks for fixing the formatting :).

@geoand
Copy link
Contributor

geoand commented Nov 23, 2021

Should this be backported to 2.5?

@geoand I think this should be backported, it's a functional fix. Anything I should do regarding backport?

You don't need to do anything, I'll add the proper label.

Thanks for fixing the formatting :).

NP!

@radcortez radcortez merged commit 549a802 into quarkusio:main Nov 23, 2021
@quarkus-bot quarkus-bot bot added this to the 2.6 - main milestone Nov 23, 2021
@gsmet gsmet modified the milestones: 2.6 - main, 2.5.1.Final Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

quarkus-rest-client-reactive related configuration properties problem
4 participants