Avoid duplicate calls to getParameterTypes and getGenericParameterTypes #21794
Conversation
|
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
Postremus
changed the title
quarkus-bot
bot
added
area/amazon-lambda
area/arc
|
Will have to rebase these changes, apperantly more was included in the commit then I originally intended. |
Postremus
force-pushed
the
less-array-clones
branch
2 times, most recently
from
c86f160 to
954c523
Compare
|
This workflow status is outdated as a new workflow run has been triggered. 🚫 This workflow run has been cancelled. Failing Jobs - Building 67ba867
|
|
This workflow status is outdated as a new workflow run has been triggered. 🚫 This workflow run has been cancelled. Failing Jobs - Building c86f160
|
Postremus
force-pushed
the
less-array-clones
branch
from
954c523 to
28eb2ad
Compare
|
This is now ready for review. |
| @@ -102,8 +103,10 @@ public Method getResourceMethod() { | |||
| } | |||
|
|
|||
| public Annotation[] getParameterAnnotations(int index) { | |||
| // Should we cache this? | |||
| return getMethod().getParameterAnnotations()[index]; | |||
| if (parameterAnnotations == null) { | |||
There was a problem hiding this comment.
Given how getMethod() looks in the same class, there's a good chance this might need a synchronization pattern.
There was a problem hiding this comment.
Yeah, I'd say let's just skip the change to this method.
There was a problem hiding this comment.
@Postremus could you revert this specific change and squash? After that I think it's good to go.
There was a problem hiding this comment.
@gsmet I will do a squash & rebase this evening (CEST).
Calling getParameterTypes or getGenericParameterTypes creates clones of the underlying arrays. Doing so during iterations is costly, so lets better not do that.
Postremus
force-pushed
the
less-array-clones
branch
from
28eb2ad to
8d08f0a
Compare
gsmet
added
the
triage/waiting-for-ci
quarkus-bot
bot
removed
the
triage/waiting-for-ci
Calling getParameterTypes or getGenericParameterTypes creates clones of the underlying arrays.
Doing so during iterations is costly, so lets better not do that.
This again saves saves a few ms. I saw both of these calls at "0,8% of all" according to the flamegraphs.
Related to #21552