Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arc - when evaluating parameter type information, handle primitive arrays properly #21900

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

manovotn
Copy link
Contributor

@manovotn manovotn commented Dec 2, 2021

This is a minor oversight from previous.
Related to this comment - #21781 (comment)

@manovotn manovotn requested a review from mkouba December 2, 2021 22:36
@quarkus-bot quarkus-bot bot added the area/arc Issue related to ARC (dependency injection) label Dec 2, 2021
@stuartwdouglas
Copy link
Member

It's not just arrays that are the issue, public types from outside application archives can also trigger this: #21901

IMHO the warning is unnecessary, as any private type would be in the same index. Any private type outside the current jar would not be accessible at compile time anyway.

@mkouba
Copy link
Contributor

mkouba commented Dec 3, 2021

IMHO the warning is unnecessary, as any private type would be in the same index. Any private type outside the current jar would not be accessible at compile time anyway.

This check is not only about private types but package-private types as well.

@mkouba mkouba merged commit bc3c036 into quarkusio:main Dec 3, 2021
@quarkus-bot quarkus-bot bot added this to the 2.6 - main milestone Dec 3, 2021
@manovotn manovotn deleted the fixDetectionOfPrimitiveArrays branch December 3, 2021 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants