Amazon Lambda - minor cleanup #2197
Merged
+146
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkouba
force-pushed
the
aws-lambda-cleanup
branch
2 times, most recently
from
68bb1f4 to
52b2cfb
Compare
evanchooly
approved these changes
Apr 24, 2019
...azon-lambda/runtime/src/main/java/io/quarkus/amazon/lambda/runtime/AmazonLambdaTemplate.java
Outdated
Show resolved
Hide resolved
| HttpURLConnection responseConnection = (HttpURLConnection) responseUrl.openConnection(); | ||
| responseConnection.setDoOutput(true); | ||
| responseConnection.setRequestMethod("POST"); | ||
| mapper.writeValue(responseConnection.getOutputStream(), response); | ||
| while (responseConnection.getInputStream().read() != -1) { | ||
|
|
||
| // Read data |
There was a problem hiding this comment.
Well, I think it reads the data until the end of the stream is reached. I've just added a comment because an empty while loop looks weird to me ;-).
mkouba
force-pushed
the
aws-lambda-cleanup
branch
from
52b2cfb to
1a72573
Compare
gsmet
reviewed
Apr 24, 2019
| public void handle(HttpServerExchange exchange, String message) { | ||
| ObjectMapper mapper = new ObjectMapper(); | ||
| try { | ||
| FunctionError result = mapper.readerFor(FunctionError.class).readValue(message); |
There was a problem hiding this comment.
I think we should cache the reader here. It can be done in another PR though as it was already preexisting. I don't know if we use this pattern elsewhere in the code.
There was a problem hiding this comment.
If it is safe to share a reader then +1 for a new PR ;-)
There was a problem hiding this comment.
Ah, I missed it's just in the tests. We don't really care then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.