Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant software.amazon.awssdk:apache-client dependency from quarkus-bom #22012

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

jamesnetherton
Copy link
Contributor

No description provided.

@quarkus-bot quarkus-bot bot added the area/dependencies Pull requests that update a dependency file label Dec 8, 2021
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@quarkus-bot
Copy link

quarkus-bot bot commented Dec 8, 2021

Failing Jobs - Building 0cd3327

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17
Native Tests - Security1 ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: extensions/opentelemetry/opentelemetry/deployment 
! Skipped: extensions/opentelemetry/opentelemetry-exporter-jaeger/deployment extensions/opentelemetry/opentelemetry-exporter-otlp/deployment integration-tests/opentelemetry and 2 more

📦 extensions/opentelemetry/opentelemetry/deployment

io.quarkus.opentelemetry.deployment.RestClientOpenTelemetryTest.client line 61 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a lambda expression in io.quarkus.opentelemetry.deployment.TestSpanExporter expected: <2> but was: <1> within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)

io.quarkus.opentelemetry.deployment.RestClientOpenTelemetryTest.urlWithoutAuthentication line 108 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Assertion condition defined as a lambda expression in io.quarkus.opentelemetry.deployment.TestSpanExporter expected: <2> but was: <3> within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)

@gsmet
Copy link
Member

gsmet commented Dec 8, 2021

@radcortez @michalszynkiewicz there's something wrong with these OpenTelemetry tests ^. I have seen them failing several times in recent PRs.

@gsmet gsmet merged commit a95ed45 into quarkusio:main Dec 8, 2021
@quarkus-bot quarkus-bot bot added this to the 2.7 - main milestone Dec 8, 2021
@jamesnetherton jamesnetherton deleted the remove-aws-apache-client-dep branch December 8, 2021 13:28
@radcortez
Copy link
Member

@radcortez @michalszynkiewicz there's something wrong with these OpenTelemetry tests ^. I have seen them failing several times in recent PRs.

Hum, I guess this is related to our change to use the batch exporter (which is Async) for testing. Let me have a look.

@gsmet gsmet modified the milestones: 2.7 - main, 2.6.0.Final Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants