Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve the application archives from TCCL #22128

Merged
merged 1 commit into from
Dec 13, 2021

Conversation

Postremus
Copy link
Member

@Postremus Postremus commented Dec 12, 2021

Prevents opening (and closing) ZFS just to check if it contains an application marker.
The new solution is seperated in 3 steps.

  • Ask TTCL for paths to the marker resources, and normalize them. This will in the end point be an artifact path.
  • Match these artifact paths to the apps runtime dependencies, resulting in a list of all application archives.
  • Index the application archives, and create ApplicationArchiveImpl's for them

This patch also removes usages of the deprecated ZipUtils.newFileSystem(Path, CL) method.

This saves about 170ms of dev mode startup time (on windows).

Related to #21552

Prevents opening (and closing) ZFS just to check if it contains an application marker.
The new solution is seperated in 3 steps.
* Ask TTCL for paths to the marker resources, and normalize them. This will in the end point be an artifact path.
* Match these artifact paths to the apps runtime dependencies, resulting in a list of all application archives.
* Index the application archives, and create ApplicationArchiveImpl's for them
This patch also removes usages of the deprecated ZipUtils.newFileSystem(Path, CL) method.
Copy link
Member

@stuartwdouglas stuartwdouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@stuartwdouglas stuartwdouglas merged commit 85316bc into quarkusio:main Dec 13, 2021
@quarkus-bot quarkus-bot bot added this to the 2.7 - main milestone Dec 13, 2021
@Postremus Postremus deleted the faster-aabs2 branch December 13, 2021 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants