Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align HTTP status codes with messages #22767

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Conversation

cdhermann
Copy link
Contributor

@cdhermann cdhermann commented Jan 10, 2022

Update HTTP status code to message mapping based on https://developer.mozilla.org/de/docs/Web/HTTP/Status.
This fixes #22765

Update status code to message mapping based on https://developer.mozilla.org/de/docs/Web/HTTP/Status
@quarkus-bot

This comment has been minimized.

@cdhermann cdhermann changed the title Fix #22765 Align HTTP status codes with messages Jan 10, 2022
@gastaldi gastaldi added area/reactive triage/backport? triage/waiting-for-ci Ready to merge when CI successfully finishes labels Jan 10, 2022
@gastaldi
Copy link
Contributor

Can you also add the test you created in the issue description?

@gsmet
Copy link
Member

gsmet commented Jan 10, 2022

I don't think it's worth adding a test for that or you would end up having to test the whole map.

@cdhermann
Copy link
Contributor Author

Can you also add the test you created in the issue description?

@gastaldi, I'm sorry to say but I don't know where the test has to be added. I don't see any tests at https://github.com/quarkusio/quarkus/tree/main/independent-projects/resteasy-reactive/common/runtime/src/ for example

@gastaldi
Copy link
Contributor

@cdhermann that's fine, you'd have to create a src/test/java under there, but as @gsmet pointed out maybe the test is not worth in this case

@gastaldi gastaldi merged commit 6071b57 into quarkusio:main Jan 10, 2022
@quarkus-bot quarkus-bot bot added this to the 2.7 - main milestone Jan 10, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jan 10, 2022
@gsmet gsmet modified the milestones: 2.7 - main, 2.6.3.Final Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Status Code and Message Mismatch in WebApplicationException
3 participants