-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use new loadClassFromTCCL method #22928
Conversation
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 6ad4430
Failures⚙️ Initial JDK 11 Build #- Failing: tcks/microprofile-context-propagation
📦 tcks/microprofile-context-propagation✖ |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 305909f
Failures⚙️ Gradle Tests - JDK 11 #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖ ⚙️ Gradle Tests - JDK 11 Windows #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖ ⚙️ JVM Tests - JDK 11 #- Failing: extensions/reactive-routes/deployment
! Skipped: extensions/agroal/deployment extensions/elytron-security-jdbc/deployment extensions/flyway/deployment and 158 more 📦 extensions/reactive-routes/deployment✖ ⚙️ JVM Tests - JDK 11 Windows #- Failing: extensions/reactive-routes/deployment
! Skipped: extensions/agroal/deployment extensions/elytron-security-jdbc/deployment extensions/flyway/deployment and 158 more 📦 extensions/reactive-routes/deployment✖ ⚙️ JVM Tests - JDK 17 #- Failing: extensions/reactive-routes/deployment
! Skipped: extensions/agroal/deployment extensions/elytron-security-jdbc/deployment extensions/flyway/deployment and 158 more 📦 extensions/reactive-routes/deployment✖ ⚙️ Native Tests - AWT, ImageIO and Java2D #- Failing: integration-tests/awt integration-tests/no-awt
📦 integration-tests/awt✖ 📦 integration-tests/no-awt✖ ⚙️ Native Tests - Amazon #- Failing: integration-tests/amazon-lambda integration-tests/amazon-lambda-http
📦 integration-tests/amazon-lambda✖ 📦 integration-tests/amazon-lambda-http✖ ⚙️ Native Tests - Cache #- Failing: integration-tests/cache integration-tests/infinispan-cache-jpa integration-tests/infinispan-client
📦 integration-tests/cache✖ 📦 integration-tests/infinispan-cache-jpa✖ 📦 integration-tests/infinispan-client✖ ⚙️ Native Tests - Data1 #- Failing: integration-tests/hibernate-orm-tenancy/connection-resolver integration-tests/hibernate-orm-tenancy/connection-resolver-legacy-qualifiers integration-tests/hibernate-orm-tenancy/datasource and 5 more
📦 integration-tests/hibernate-orm-tenancy/connection-resolver✖ 📦 integration-tests/hibernate-orm-tenancy/connection-resolver-legacy-qualifiers✖ 📦 integration-tests/hibernate-orm-tenancy/datasource✖ 📦 integration-tests/jpa-derby✖ 📦 integration-tests/jpa-h2✖ 📦 integration-tests/jpa-mariadb✖ 📦 integration-tests/jpa-mssql✖ 📦 integration-tests/jpa-without-entity✖ ⚙️ Native Tests - Data2 #- Failing: integration-tests/jpa integration-tests/jpa-db2 integration-tests/jpa-mapping-xml/modern-app and 2 more
📦 integration-tests/jpa✖ ✖ ✖ ✖ 📦 integration-tests/jpa-db2✖ 📦 integration-tests/jpa-mapping-xml/modern-app✖ ✖ 📦 integration-tests/jpa-mysql✖ 📦 integration-tests/jpa-oracle✖ ⚙️ Native Tests - Data3 #- Failing: integration-tests/flyway integration-tests/hibernate-orm-envers integration-tests/hibernate-orm-panache and 3 more
📦 integration-tests/flyway✖ 📦 integration-tests/hibernate-orm-envers✖ 📦 integration-tests/hibernate-orm-panache✖ 📦 integration-tests/hibernate-orm-panache-kotlin✖ 📦 integration-tests/liquibase✖ 📦 integration-tests/liquibase-mongodb✖ ⚙️ Native Tests - Data4 #- Failing: integration-tests/hibernate-orm-rest-data-panache integration-tests/mongodb-rest-data-panache integration-tests/redis-client
📦 integration-tests/hibernate-orm-rest-data-panache✖ 📦 integration-tests/mongodb-rest-data-panache✖ 📦 integration-tests/redis-client✖ ⚙️ Native Tests - Data5 #- Failing: integration-tests/hibernate-orm-tenancy/schema integration-tests/hibernate-reactive-postgresql integration-tests/jpa-postgresql and 3 more
📦 integration-tests/hibernate-orm-tenancy/schema✖ 📦 integration-tests/hibernate-reactive-postgresql✖ 📦 integration-tests/jpa-postgresql✖ 📦 integration-tests/jpa-postgresql-withxml✖ 📦 integration-tests/narayana-jta✖ 📦 integration-tests/reactive-pg-client✖ ⚙️ Native Tests - Data6 #- Failing: integration-tests/elasticsearch-rest-client integration-tests/elasticsearch-rest-high-level-client integration-tests/hibernate-reactive-panache and 3 more
📦 integration-tests/elasticsearch-rest-client✖ 📦 integration-tests/elasticsearch-rest-high-level-client✖ 📦 integration-tests/hibernate-reactive-panache✖ 📦 integration-tests/hibernate-search-orm-elasticsearch✖ 📦 integration-tests/hibernate-search-orm-elasticsearch-tenancy✖ 📦 integration-tests/hibernate-search-orm-opensearch✖ ⚙️ Native Tests - Data7 #- Failing: integration-tests/hibernate-reactive-db2 integration-tests/hibernate-reactive-mysql integration-tests/reactive-db2-client and 1 more
📦 integration-tests/hibernate-reactive-db2✖ 📦 integration-tests/hibernate-reactive-mysql✖ 📦 integration-tests/reactive-db2-client✖ 📦 integration-tests/reactive-mysql-client✖ ⚙️ Native Tests - DevTools Integration Tests #- Failing: integration-tests/devtools-registry-client
📦 integration-tests/devtools-registry-client✖ ⚙️ Native Tests - HTTP #- Failing: integration-tests/elytron-resteasy integration-tests/elytron-resteasy-reactive integration-tests/rest-client and 10 more
📦 integration-tests/elytron-resteasy✖ 📦 integration-tests/elytron-resteasy-reactive✖ 📦 integration-tests/rest-client✖ 📦 integration-tests/rest-client-reactive✖ 📦 integration-tests/rest-client-reactive-multipart✖ 📦 integration-tests/rest-client-reactive-stork✖ 📦 integration-tests/resteasy-jackson✖ 📦 integration-tests/resteasy-reactive-kotlin/standard✖ 📦 integration-tests/vertx✖ 📦 integration-tests/vertx-graphql✖ 📦 integration-tests/vertx-http✖ 📦 integration-tests/vertx-web✖ 📦 integration-tests/vertx-web-jackson✖ ⚙️ Native Tests - Main #- Failing: integration-tests/main
📦 integration-tests/main✖ ⚙️ Native Tests - Messaging1 #- Failing: integration-tests/kafka integration-tests/kafka-avro integration-tests/kafka-avro-apicurio2 and 6 more
📦 integration-tests/kafka✖ 📦 integration-tests/kafka-avro✖ 📦 integration-tests/kafka-avro-apicurio2✖ 📦 integration-tests/kafka-oauth-keycloak✖ 📦 integration-tests/kafka-sasl✖ 📦 integration-tests/kafka-snappy✖ 📦 integration-tests/kafka-ssl✖ 📦 integration-tests/kafka-streams✖ 📦 integration-tests/reactive-messaging-kafka✖ ⚙️ Native Tests - Messaging2 #- Failing: integration-tests/reactive-messaging-amqp integration-tests/reactive-messaging-rabbitmq integration-tests/reactive-messaging-rabbitmq-dyn
📦 integration-tests/reactive-messaging-amqp✖ 📦 integration-tests/reactive-messaging-rabbitmq✖ 📦 integration-tests/reactive-messaging-rabbitmq-dyn✖ ⚙️ Native Tests - Misc1 #- Failing: integration-tests/jackson integration-tests/jsonb integration-tests/kotlin-serialization and 6 more
📦 integration-tests/jackson✖ 📦 integration-tests/jsonb✖ 📦 integration-tests/kotlin-serialization✖ 📦 integration-tests/logging-min-level-set✖ 📦 integration-tests/logging-min-level-unset✖ 📦 integration-tests/maven✖ 📦 integration-tests/quartz✖ 📦 integration-tests/qute✖ 📦 integration-tests/simple with space✖ ⚙️ Native Tests - Misc2 #- Failing: integration-tests/hibernate-validator integration-tests/logging-gelf integration-tests/mailer and 2 more
📦 integration-tests/hibernate-validator✖ 📦 integration-tests/logging-gelf✖ 📦 integration-tests/mailer✖ 📦 integration-tests/native-config-profile✖ ✖ ✖ ✖ 📦 integration-tests/test-extension✖ ⚙️ Native Tests - Misc3 #- Failing: integration-tests/kubernetes-client integration-tests/kubernetes-service-binding-jdbc integration-tests/openshift-client and 5 more
📦 integration-tests/kubernetes-client✖ ✖ ✖ ✖ 📦 integration-tests/kubernetes-service-binding-jdbc✖ 📦 integration-tests/openshift-client✖ 📦 integration-tests/smallrye-config✖ 📦 integration-tests/smallrye-graphql✖ 📦 integration-tests/smallrye-graphql-client✖ 📦 integration-tests/smallrye-metrics✖ 📦 integration-tests/smallrye-opentracing✖ ⚙️ Native Tests - Misc4 #- Failing: integration-tests/gradle integration-tests/jaxb integration-tests/jaxp and 5 more
📦 integration-tests/gradle✖ ✖ 📦 integration-tests/jaxb✖ 📦 integration-tests/jaxp✖ 📦 integration-tests/logging-json✖ 📦 integration-tests/micrometer-mp-metrics✖ 📦 integration-tests/micrometer-prometheus✖ 📦 integration-tests/opentelemetry✖ 📦 integration-tests/picocli-native✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ✖ ⚙️ Native Tests - Security1 #- Failing: integration-tests/bouncycastle integration-tests/bouncycastle-fips integration-tests/elytron-security and 4 more
📦 integration-tests/bouncycastle✖ 📦 integration-tests/bouncycastle-fips✖ 📦 integration-tests/elytron-security✖ 📦 integration-tests/elytron-security-jdbc✖ 📦 integration-tests/elytron-security-ldap✖ 📦 integration-tests/elytron-security-oauth2✖ 📦 integration-tests/elytron-undertow✖ ⚙️ Native Tests - Security2 #- Failing: integration-tests/oidc integration-tests/oidc-client integration-tests/oidc-client-reactive and 5 more
📦 integration-tests/oidc✖ 📦 integration-tests/oidc-client✖ 📦 integration-tests/oidc-client-reactive✖ 📦 integration-tests/oidc-client-wiremock✖ 📦 integration-tests/oidc-code-flow✖ 📦 integration-tests/oidc-tenancy✖ 📦 integration-tests/oidc-token-propagation✖ 📦 integration-tests/oidc-wiremock✖ ⚙️ Native Tests - Security3 #- Failing: integration-tests/keycloak-authorization integration-tests/smallrye-jwt-token-propagation
📦 integration-tests/keycloak-authorization✖ 📦 integration-tests/smallrye-jwt-token-propagation✖ ⚙️ Native Tests - Spring #- Failing: integration-tests/spring-boot-properties integration-tests/spring-cloud-config-client integration-tests/spring-data-jpa and 3 more
📦 integration-tests/spring-boot-properties✖ 📦 integration-tests/spring-cloud-config-client✖ 📦 integration-tests/spring-data-jpa✖ 📦 integration-tests/spring-data-rest✖ 📦 integration-tests/spring-di✖ 📦 integration-tests/spring-web✖ ⚙️ Native Tests - Windows - RESTEasy Jackson #- Failing: integration-tests/resteasy-jackson
📦 integration-tests/resteasy-jackson✖ ⚙️ Native Tests - gRPC #- Failing: integration-tests/grpc-interceptors integration-tests/grpc-mutual-auth integration-tests/grpc-plain-text-gzip and 3 more
📦 integration-tests/grpc-interceptors✖ 📦 integration-tests/grpc-mutual-auth✖ 📦 integration-tests/grpc-plain-text-gzip✖ 📦 integration-tests/grpc-plain-text-mutiny✖ 📦 integration-tests/grpc-proto-v2✖ 📦 integration-tests/grpc-tls✖ |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building d40c469
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
⚙️ Gradle Tests - JDK 11 Windows #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
⚙️ JVM Tests - JDK 11 #- Failing: extensions/reactive-routes/deployment
! Skipped: extensions/agroal/deployment extensions/elytron-security-jdbc/deployment extensions/flyway/deployment and 158 more 📦 extensions/reactive-routes/deployment✖
⚙️ JVM Tests - JDK 11 Windows #- Failing: extensions/reactive-routes/deployment
! Skipped: extensions/agroal/deployment extensions/elytron-security-jdbc/deployment extensions/flyway/deployment and 158 more 📦 extensions/reactive-routes/deployment✖
⚙️ JVM Tests - JDK 17 #- Failing: extensions/reactive-routes/deployment
! Skipped: extensions/agroal/deployment extensions/elytron-security-jdbc/deployment extensions/flyway/deployment and 158 more 📦 extensions/reactive-routes/deployment✖
⚙️ Native Tests - HTTP #- Failing: integration-tests/vertx-web
📦 integration-tests/vertx-web✖
|
f839e4c
to
16eecb5
Compare
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 16eecb5
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
⚙️ Gradle Tests - JDK 11 Windows #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
⚙️ JVM Tests - JDK 11 #- Failing: integration-tests/devmode
📦 integration-tests/devmode✖
✖
✖
⚙️ JVM Tests - JDK 11 Windows #- Failing: integration-tests/devmode
📦 integration-tests/devmode✖
✖
✖
⚙️ JVM Tests - JDK 17 #- Failing: integration-tests/devmode
📦 integration-tests/devmode✖
✖
✖
|
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 835f5c0
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
⚙️ Gradle Tests - JDK 11 Windows #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
|
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 24b7d3c
Full information is available in the Build summary check run. Failures⚙️ Devtools Tests - JDK 11 #- Failing: integration-tests/devtools
📦 integration-tests/devtools✖
✖
✖
✖
✖
✖
📦 integration-tests/devtools/target/quarkus-codestart-build-test/project-maven-java-a96d11d0-afbe-443a-9d08-e3f2394e53d1✖
⚙️ JVM Tests - JDK 11 #- Failing: extensions/grpc/deployment
! Skipped: integration-tests/devmode integration-tests/grpc-health integration-tests/grpc-hibernate and 8 more 📦 extensions/grpc/deployment✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
⚙️ Native Tests - gRPC #- Failing: integration-tests/grpc-mutual-auth integration-tests/grpc-plain-text-mutiny
📦 integration-tests/grpc-mutual-auth✖
✖
✖
✖
📦 integration-tests/grpc-plain-text-mutiny✖
✖
✖
✖
✖
✖
✖
✖
✖
✖
|
@stuartwdouglas @geoand @gsmet Are you sure this is really needed everywhere? For example, the generated bean metadata now contains something like: public Class getScope() {
ClassLoader var1 = Thread.currentThread().getContextClassLoader();
return Class.forName("javax.inject.Singleton", (boolean) 0, var1);
} and previously it was just: public Class getScope() {
return Singleton.class;
} The new approach is far less efficient and may cause performance drop in hot paths. Furhtermore, classes representing the primitive type are also loaded via TCCL (see for example https://github.com/quarkusio/quarkus/pull/22928/files#diff-623909fc5ebbbf020d893adc38a3cac083e6bb2953e8a15360b38958c2521b53R155). |
It is not needed everywhere, so I would say let's switch it back in the places where it makes sense |
In general this is 'safest', as it is always correct, I did not really think about the hot path thing though as I was not really aware it would be in the hot path. Can we just change it back for the few places it is in the hot path? |
I am not looking at it |
- it should not be needed and it reduces the performance - revert the changes introduced by quarkusio#22928
- it should not be needed and it reduces the performance - revert the changes introduced by quarkusio#22928 (cherry picked from commit 6266253)
Fixes #21250