Allow injection of EMF into CDI beans #23
Conversation
|
This enables support for injecting the EntityManagerFactory, with support for the EntityManager still to come (it requires the TransactionalEntityManager stuff to be ported from WildFly). |
| import javax.persistence.EntityManager; | ||
| import javax.persistence.PersistenceUnit; | ||
|
|
||
| public class JpaProducer { |
There was a problem hiding this comment.
Is that one a not yet working area?
|
|
||
|
|
||
| @RunWith(GraalTest.class) | ||
| public class JPABootstrapITCase extends JPABootstrapTestCase { |
There was a problem hiding this comment.
It looks like this new class is doing the same job as JPABootstrapInGraalITCase. Is that correct? If yes I will remove JPABootstrapInGraalITCase.
There was a problem hiding this comment.
Oops, I thought I had, it I must have missed commiting the deletion.
| } | ||
| } | ||
| } | ||
| knownUnitNames.remove(""); //TODO: support for the default PU |
There was a problem hiding this comment.
Any specific reason you remove it now?
There was a problem hiding this comment.
Because I don't have a way to figure out what the default PU is. To do this I need to move the persistence.xml processing earlier (and basically have it done by shamrock instead on hibernate-protean).
There was a problem hiding this comment.
Interestingly, I will need to have Shamrock be fed persistence.xml info too to fix John's class visibility problem. I'm hoping Hibernate can feed this back to me instead of having to reproduce part of the logic in Shamrock.
There was a problem hiding this comment.
hibernate-protean already handles this parsing, and with some changes it should be possible to make it work in Shamrock. The results of the parsing look like they are bytecode serializable so it should be easy to make them get parsed at build time, to remove the need to load XML parsers at runtime.
This would require some changed in hibernate-protean though, as at the moment there is no way to control the order.
stuartwdouglas
force-pushed
the
em-inject
branch
from
9a6fb2d to
ae4e508
Compare
when committed then issues with label `kind/epic` will on
open/edit/labeling have
a section like:
```
<!-- EPIC:DATA
#23 quarkusio#445 #44
-->
```
Expanded to a task list with link to issue + title header.
the checkbox will reflect wether open or closed at the time of
edit of the issue.
(we can potentially improve that in future)
Includes update to epic template and disables debug printing as
to speed things up a bit.
when committed then issues with label `kind/epic` will on
open/edit/labeling have
a section like:
```
<!-- EPIC:DATA
#23 quarkusio#445 #44
-->
```
Expanded to a task list with link to issue + title header.
the checkbox will reflect wether open or closed at the time of
edit of the issue.
(we can potentially improve that in future)
Includes update to epic template and disables debug printing as
to speed things up a bit.
No description provided.