-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev console and UI for listing running dev services #23048
Conversation
ozangunalp
commented
Jan 20, 2022
- Refactoring for the dev services to produce build items even though a running dev service already exists.
- Dev console commands In dev mode: [c] for getting the status of running containers, [g] for following container logs on the console
- Dev UI for listing services and injected configs.
Nice work! I haven't looked at the code but here are a couple of comments on the UI:
|
This seems like a decent start of a solution for #22943. |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 5729d77
Failures⚙️ Initial JDK 11 Build #- Failing: extensions/oidc-client-filter/deployment
! Skipped: docs integration-tests/oidc-client integration-tests/oidc-client-wiremock and 1 more 📦 extensions/oidc-client-filter/deployment✖ |
@Ladicek 👍 I didn't see #22943 before starting to work on this, but it's the same idea. I'll look to open a shell on the container from dev console. And I'll try to find a place to add some tests... |
5729d77
to
89454ad
Compare
@ozangunalp I was not talking about opening a shell, just providing the command line you can use to connect from your host when it makes sense. So it's just about formatting a string with the proper info. |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 3be0e98
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
⚙️ JVM Tests - JDK 11 #- Failing: extensions/smallrye-reactive-messaging-amqp/deployment integration-tests/devmode integration-tests/grpc-hibernate and 1 more
! Skipped: integration-tests/reactive-messaging-amqp 📦 extensions/smallrye-reactive-messaging-amqp/deployment✖
✖
✖
✖
✖
📦 integration-tests/devmode✖
✖
📦 integration-tests/grpc-hibernate✖
📦 integration-tests/reactive-messaging-rabbitmq-dyn✖
⚙️ JVM Tests - JDK 11 Windows #- Failing: extensions/smallrye-reactive-messaging-amqp/deployment integration-tests/devmode
! Skipped: integration-tests/reactive-messaging-amqp 📦 extensions/smallrye-reactive-messaging-amqp/deployment✖
✖
✖
✖
✖
📦 integration-tests/devmode✖
✖
⚙️ JVM Tests - JDK 17 #- Failing: extensions/smallrye-reactive-messaging-amqp/deployment integration-tests/devmode integration-tests/reactive-messaging-rabbitmq-dyn
! Skipped: integration-tests/reactive-messaging-amqp 📦 extensions/smallrye-reactive-messaging-amqp/deployment✖
✖
✖
✖
✖
📦 integration-tests/devmode✖
✖
📦 integration-tests/reactive-messaging-rabbitmq-dyn✖
⚙️ Native Tests - Messaging2 #- Failing: integration-tests/reactive-messaging-amqp integration-tests/reactive-messaging-rabbitmq-dyn
📦 integration-tests/reactive-messaging-amqp✖
📦 integration-tests/reactive-messaging-rabbitmq-dyn✖
|
3be0e98
to
abd4fa7
Compare
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building abd4fa7
Failures⚙️ Initial JDK 11 Build #- Failing: extensions/panache/hibernate-orm-panache-kotlin/deployment
! Skipped: docs integration-tests/hibernate-orm-panache-kotlin 📦 extensions/panache/hibernate-orm-panache-kotlin/deployment✖ |
abd4fa7
to
2a4e018
Compare
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 2a4e018
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 Windows #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
✖
✖
⚙️ JVM Tests - JDK 11 Windows #- Failing: extensions/agroal/deployment extensions/smallrye-reactive-messaging-amqp/deployment
! Skipped: extensions/elytron-security-jdbc/deployment extensions/flyway/deployment extensions/hibernate-envers/deployment and 101 more 📦 extensions/agroal/deployment✖
✖
📦 extensions/smallrye-reactive-messaging-amqp/deployment✖
✖
✖
|
2a4e018
to
05224de
Compare
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 05224de
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 17 #- Failing: integration-tests/container-image/maven-invoker-way
📦 integration-tests/container-image/maven-invoker-way✖ 📦 integration-tests/container-image/maven-invoker-way/target/it/container-build-with-keycloak✖
✖
|
7e517c9
to
f7f54b8
Compare
...ployment/src/main/java/io/quarkus/deployment/builditem/DevServicesConfigResultBuildItem.java
Outdated
Show resolved
Hide resolved
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 2fc409a
Full information is available in the Build summary check run. Failures⚙️ Gradle Tests - JDK 11 Windows #- Failing: integration-tests/gradle
📦 integration-tests/gradle✖
|
2fc409a
to
e1f394d
Compare
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building e1f394d
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 Windows #- Failing: extensions/smallrye-reactive-messaging-amqp/deployment
! Skipped: integration-tests/reactive-messaging-amqp 📦 extensions/smallrye-reactive-messaging-amqp/deployment✖
|
0c76f27
to
62f3666
Compare
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 62f3666
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 #- Failing: integration-tests/devmode
📦 integration-tests/devmode✖
⚙️ JVM Tests - JDK 11 Windows #- Failing: integration-tests/devmode
📦 integration-tests/devmode✖
⚙️ JVM Tests - JDK 17 #- Failing: integration-tests/devmode
📦 integration-tests/devmode✖
|
62f3666
to
ef0c963
Compare
@stuartwdouglas thanks for this! I started doing exactly this to not add a new module but I couldn't render things inside dev UI without a runtime class. |
Exclude junit from keycloak test server dependency
…ices Deprecate DevServicesConfigResultBuildItem properly
This has been split up into various deployment modules instead
ef0c963
to
e895d85
Compare
Failing Jobs - Building e895d85
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 Windows #- Failing: extensions/resteasy-classic/resteasy/deployment
! Skipped: extensions/agroal/deployment extensions/apicurio-registry-avro/deployment extensions/avro/deployment and 286 more 📦 extensions/resteasy-classic/resteasy/deployment✖
|
@gsmet I think your concerns have been addressed |
@gsmet @stuartwdouglas Do you have anything else in mind before we merge this? |
I dismissed my review as my concerns have been addressed. @phillip-kruger maybe you could have a look at this one from the UI side? Either now or after merging? |
This is very nice ! I can have a look at the UI, but maybe after merge... |
Yes, probably better after merge. I'll let @stuartwdouglas approve and merge this one. |
see #23636 for a potential screen update. |