Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use idiomatic Kotlin in REST Assured tests #23124

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Use idiomatic Kotlin in REST Assured tests #23124

merged 1 commit into from
Jan 25, 2022

Conversation

geoand
Copy link
Contributor

@geoand geoand commented Jan 24, 2022

No description provided.

@geoand geoand requested a review from evanchooly January 24, 2022 06:54
@geoand geoand force-pushed the rest-assured-kotlin branch from f4723af to 371e1e1 Compare January 24, 2022 12:02
@geoand geoand requested a review from gsmet January 25, 2022 09:40
gsmet
gsmet approved these changes Jan 25, 2022
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me less Kotlin is better Kotlin but YMMV :).

@geoand
Copy link
Contributor Author

geoand commented Jan 25, 2022

I'm also sceptical about various Koltin features, but I think this little RestAssured DSL improves things

@geoand geoand merged commit 6b42ad3 into quarkusio:main Jan 25, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Jan 25, 2022
@geoand geoand deleted the rest-assured-kotlin branch January 25, 2022 10:34
@gsmet
Copy link
Member

gsmet commented Feb 21, 2022

Backported to avoid conflicts.

@gsmet gsmet modified the milestones: 2.8 - main, 2.7.2.Final Feb 21, 2022
@geoand
Copy link
Contributor Author

geoand commented Feb 21, 2022

Good idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsmet gsmet gsmet approved these changes

@evanchooly evanchooly Awaiting requested review from evanchooly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.7.2.Final
Development

Successfully merging this pull request may close these issues.
2 participants
@geoand @gsmet