Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade SmallRye Health to 3.2.0 #23206

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Conversation

xstefank
Copy link
Member

No description provided.

@quarkus-bot quarkus-bot bot added area/dependencies Pull requests that update a dependency file area/health area/smallrye labels Jan 26, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Jan 26, 2022

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building b52389c

Status Name Step Failures Logs Raw logs
Initial JDK 11 Build Build Failures Logs Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: extensions/smallrye-health/runtime 
! Skipped: devtools/bom-descriptor-json docs extensions/agroal/deployment and 218 more

📦 extensions/smallrye-health/runtime

Failed to execute goal net.revelc.code:impsort-maven-plugin:1.6.2:check (check-imports) on project quarkus-smallrye-health: Imports are not sorted in /home/runner/work/quarkus/quarkus/extensions/smallrye-health/runtime/src/main/java/io/quarkus/smallrye/health/runtime/SmallRyeHealthRecorder.java

<exclusions>
<exclusion>
<groupId>jakarta.json</groupId>
<artifactId>jakarta.json-api</artifactId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question, do you need JSON-P around or is it just optional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, we also now have a non-CDI plain option of using sr-health so I needed to ship this too, unfortunately.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah OK, I just checked and the dependency is already there. Fine then.

@quarkus-bot
Copy link

quarkus-bot bot commented Jan 26, 2022

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building ece5ceb

Status Name Step Failures Logs Raw logs
Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs
MicroProfile TCKs Tests Verify ⚠️ Check → Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

io.quarkus.gradle.devmode.BasicKotlinApplicationModuleDevModeTest.main line 19 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

@gsmet
Copy link
Member

gsmet commented Jan 26, 2022

I requested another CI run as I would have to get the MP TCK tests green (it's CP who made the build stall but we didn't have a clear report of the Health TCK status).

@gsmet gsmet merged commit 4d26f59 into quarkusio:main Jan 27, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Jan 27, 2022
@xstefank xstefank deleted the health-3.2.0 branch January 27, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies Pull requests that update a dependency file area/health area/smallrye
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants