Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add websockets integration tests #23238

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Add websockets integration tests #23238

merged 1 commit into from
Jan 27, 2022

Conversation

gastaldi
Copy link
Contributor

No description provided.

@gastaldi gastaldi force-pushed the websockets branch 2 times, most recently from 2567f0c to 1218d01 Compare January 27, 2022 15:32
@quarkus-bot quarkus-bot bot added the area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure label Jan 27, 2022
geoand
geoand reviewed Jan 27, 2022
View reviewed changes
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't already have something like this?

@gastaldi
Copy link
Contributor Author

I thought we had but I couldn't find it

@gsmet gsmet merged commit 777d821 into quarkusio:main Jan 27, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Jan 27, 2022
@famod
Copy link
Member

famod commented Jan 27, 2022 •
edited
Loading

Late to the party, I know, but w.r.t.:

I thought we had but I couldn't find it

What about https://github.com/quarkusio/quarkus/blob/main/integration-tests/main/src/test/java/io/quarkus/it/main/WebsocketTestCase.java ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoand geoand geoand approved these changes

@stuartwdouglas stuartwdouglas Awaiting requested review from stuartwdouglas

@famod famod Awaiting requested review from famod

@gsmet gsmet Awaiting requested review from gsmet

Assignees
No one assigned
Labels
area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/websockets
Projects
None yet
Milestone
2.8.0.CR1
Development

Successfully merging this pull request may close these issues.
4 participants
@gastaldi @famod @geoand @gsmet