Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register kotlin reflection information for native image builds #23419

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Register kotlin reflection information for native image builds #23419

merged 1 commit into from
Feb 15, 2022

Conversation

evanchooly
Copy link
Member

fixes #8479

@evanchooly evanchooly requested a review from geoand February 3, 2022 17:53
Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance we can update the Kotlin integration test to incorporate the case this addresses?

@evanchooly
Copy link
Member Author

I can tweak what's there, I think. I'll take a look. i was using the reproducer to test it. it's pretty basic but at least failed without this patch. I'm afraid any test will forever have holes of unknown size due to the nature of reflection but something is better than nothing I suppose.

@geoand
Copy link
Contributor

geoand commented Feb 3, 2022

Yeah, we can't capture everything, but we can at least cover cases we know about

@quarkus-bot
Copy link

quarkus-bot bot commented Feb 3, 2022

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 7d05101

Status Name Step Failures Logs Raw logs
Native Tests - Data3 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Native Tests - Data3 #

- Failing: integration-tests/hibernate-orm-panache-kotlin 

📦 integration-tests/hibernate-orm-panache-kotlin

io.quarkus.it.panache.KotlinPanacheFunctionalityInGraalITCase.testPanacheSerialisation - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.

@gsmet
Copy link
Member

gsmet commented Feb 7, 2022

CI is not happy about this one.

@evanchooly
Copy link
Member Author

That's odd. it's complaining about missing JAXB classes.

@quarkus-bot
Copy link

quarkus-bot bot commented Feb 7, 2022

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 5f2cea6

Status Name Step Failures Logs Raw logs
Maven Tests - JDK 11 Windows Build ⚠️ Check → Logs Raw logs
Native Tests - Data3 Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Native Tests - Data3 #

- Failing: integration-tests/hibernate-orm-panache-kotlin 

📦 integration-tests/hibernate-orm-panache-kotlin

io.quarkus.it.panache.KotlinPanacheFunctionalityInGraalITCase.testPanacheSerialisation - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
Response body doesn't match expectation.

@quarkus-bot quarkus-bot bot added the area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure label Feb 7, 2022
@gsmet
Copy link
Member

gsmet commented Feb 8, 2022

This needs a rebase (and a squash!).

@evanchooly
Copy link
Member Author

it'll get one. i'm just trying to validate that test. i can't get it to run locally (always says tests are skipped) so I'm seeing what CI does with it. (There's also an intentional test failure condition.)

@quarkus-bot
Copy link

quarkus-bot bot commented Feb 8, 2022

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 2389176

Status Name Step Failures Logs Raw logs
Native Tests - HTTP Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Native Tests - HTTP #

- Failing: integration-tests/resteasy-reactive-kotlin/standard 

📦 integration-tests/resteasy-reactive-kotlin/standard

io.quarkus.it.resteasy.reactive.kotlin.NativeGreetingResourceIT.testCreateAndFetch - More details - Source on GitHub

java.lang.AssertionError: 
2 expectations failed.
Expected status code <201> but was <500>.

io.quarkus.it.resteasy.reactive.kotlin.NativeGreetingResourceIT.testDataClassAndCustomFilters - More details - Source on GitHub

java.lang.AssertionError: 
1 expectation failed.
JSON path message doesn't match.

@geoand
Copy link
Contributor

geoand commented Feb 11, 2022

The CI failure is relevant.

BTW, you can run the integration locally test like so:

mvn verify -f integration-tests/resteasy-reactive-kotlin/standard/ -Dtest-containers -Dstart-containers

@evanchooly
Copy link
Member Author

yeah. i'm working on it. juggling a few things so it's slower going than i'd like.

@evanchooly evanchooly requested a review from geoand February 14, 2022 23:39
@geoand geoand merged commit 6d24576 into quarkusio:main Feb 15, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Feb 15, 2022
@gsmet gsmet modified the milestones: 2.8 - main, 2.7.2.Final Feb 21, 2022
@evanchooly evanchooly deleted the kotlinReflection branch March 3, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/infra-automation anything related to CI, bots, etc. that are used to automated our infrastructure area/kotlin kind/bugfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kotlin reflection fails in native build in some cases that Java reflection success
3 participants