-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register kotlin reflection information for native image builds #23419
Conversation
extensions/kotlin/deployment/src/main/java/io/quarkus/kotlin/deployment/KotlinProcessor.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any chance we can update the Kotlin integration test to incorporate the case this addresses?
I can tweak what's there, I think. I'll take a look. i was using the reproducer to test it. it's pretty basic but at least failed without this patch. I'm afraid any test will forever have holes of unknown size due to the nature of reflection but something is better than nothing I suppose. |
Yeah, we can't capture everything, but we can at least cover cases we know about |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 7d05101
Full information is available in the Build summary check run. Failures⚙️ Native Tests - Data3 #- Failing: integration-tests/hibernate-orm-panache-kotlin
📦 integration-tests/hibernate-orm-panache-kotlin✖
|
CI is not happy about this one. |
That's odd. it's complaining about missing JAXB classes. |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 5f2cea6
Full information is available in the Build summary check run. Failures⚙️ Native Tests - Data3 #- Failing: integration-tests/hibernate-orm-panache-kotlin
📦 integration-tests/hibernate-orm-panache-kotlin✖
|
extensions/kotlin/deployment/src/main/java/io/quarkus/kotlin/deployment/KotlinProcessor.java
Show resolved
Hide resolved
This needs a rebase (and a squash!). |
it'll get one. i'm just trying to validate that test. i can't get it to run locally (always says tests are skipped) so I'm seeing what CI does with it. (There's also an intentional test failure condition.) |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 2389176
Full information is available in the Build summary check run. Failures⚙️ Native Tests - HTTP #- Failing: integration-tests/resteasy-reactive-kotlin/standard
📦 integration-tests/resteasy-reactive-kotlin/standard✖
✖
|
The CI failure is relevant. BTW, you can run the integration locally test like so:
|
yeah. i'm working on it. juggling a few things so it's slower going than i'd like. |
fixes #8479