Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent structure in the jdbc deployment pom.xml files #23475

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

Sanne
Copy link
Member

@Sanne Sanne commented Feb 7, 2022

For consistency, and also because some of these modules started to have integration tests which aren't necessarily related to DevServices, so the "full skip" we used was misleading.

@Sanne Sanne requested a review from famod February 7, 2022 11:01
@quarkus-bot quarkus-bot bot added the area/persistence OBSOLETE, DO NOT USE label Feb 7, 2022
@Sanne Sanne changed the title Consistent structure in the jdbc deployment artifacts to disable DevS… Consistent structure in the jdbc deployment pom.xml files Feb 7, 2022
@quarkusio quarkusio deleted a comment from quarkus-bot bot Feb 7, 2022
Copy link
Member

@famod famod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

For that oracle PR I was thinking about a @Tag instead, but it doensn't make much of a difference.

@geoand geoand merged commit 7dc4973 into quarkusio:main Feb 7, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Feb 7, 2022
@Sanne Sanne deleted the DevServiceTests branch February 7, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/persistence OBSOLETE, DO NOT USE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants