-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce JSON logging #2348
Introduce JSON logging #2348
Conversation
So here's an interesting speed bump. If I want to enable JSON logging, I need the JSONP libraries. However we definitely don't want them if it's not going to be enabled. Should we always fold in the JSON libraries? Or, should we allow an incomplete class path in this case? |
Alternatively I could introduce an entire extension mechanism for formatter type, and then we'd have a |
For now I've just added the JSON library as a core dependency. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added an important question inline. Could you take a look?
@@ -43,6 +43,10 @@ | |||
<groupId>io.smallrye</groupId> | |||
<artifactId>smallrye-config</artifactId> | |||
</dependency> | |||
<dependency> | |||
<groupId>org.glassfish</groupId> | |||
<artifactId>javax.json</artifactId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't say I'm excited to add a dependency to javax JSON in the core.I have another question: does it work for a native executable? I would have expected the quarkus-jsonp
extension to be necessary.
If so, it makes the case of a specific extension IMHO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seemed to work. But yeah maybe a specific extension is warranted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the record - quarkus-jsonp
only registers org.glassfish.json.JsonProviderImpl
for reflection so that javax.json.spi.JsonProvider
could instantiate the class.
|
@dmlloyd do you want me to merge this and create an issue for the dedicated extension? Or other preference? |
I think it should be reworked to be a separate extension. I just haven't gotten around to it yet. If you want, we can close the PR for now to reduce clutter, and I'll reopen it if/when it's ready. |
I think this should definitely be a seperate extension. We don't want to introduce any additional core dependencies unless we absolutely have to. |
@dmlloyd Should we close this PR and get some fresh start around a separate extension? |
Sure. |
Thanks! |
Fixes #1847