Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in native reference guide #23509

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Typo in native reference guide #23509

merged 1 commit into from
Feb 8, 2022

Conversation

loicmathieu
Copy link
Contributor

I also remove some bash shell prompt that contains # as it's the comment char is bash and shows up in the guide as a comment line instead of an command line

I also remove some bash shell prompt that contains `#` as it's the comment char is bash and shows up in the guide as a comment line instead of an command line
@geoand geoand merged commit b6b6ba7 into main Feb 8, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Feb 8, 2022
@geoand geoand deleted the native-reference-guide-typ branch February 8, 2022 11:18
@gsmet
Copy link
Member

gsmet commented Feb 8, 2022

A bit too late but I'm not sure about this.

We use # to make the user aware that it should be run as root. It's a rather widespread convention.

I wonder if we should rather just keep # and disable the bash syntax highlighting which doesn't bring anything really.

@loicmathieu
Copy link
Contributor Author

@gsmet perf and FlameGraph can be run as non-root and there is sysctl equivalent to the other one.

As I'll make a followup update from podman => docker I'll update the following commands to their sysctl equivalent

echo -1 | sudo tee /proc/sys/kernel/perf_event_paranoid
echo 0 | sudo tee /proc/sys/kernel/kptr_restrict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants