Always use runtime config in schema management features #23556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E.g. default schema when recreating DB or validating DB.
quarkus-bot
bot
added
area/hibernate-orm
|
I tested manually that this fixes the problem in the reproducer mentioned in #23445 . I did not add a non-regression test because it's a bit hard to recreate the conditions where schema validation fails with H2. |
gsmet
approved these changes
Feb 9, 2022
gsmet
added
the
triage/waiting-for-ci
quarkus-bot
bot
added
kind/bugfix
and removed
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E.g. default schema when recreating DB or validating DB.
The problem was simply that
SchemaManagementIntegratorwas ignoring all runtime settings in this class. Since the default schema recently switched from build-time settings to runtime settings,SchemaManagementIntegratorstarted ignoring it.Fixes #23445