Improve the DNS lookup support in native mode for the Mongo connection using mongo:srv:// #23585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n using mongo:srv://
geoand
reviewed
Feb 11, 2022
| * DNS lookup. It can be useful to understand why the lookup fails. | ||
| */ | ||
| @ConfigItem(name = "native.dns.log-activity", defaultValue = "false") | ||
| public Optional<Boolean> dnsLookupLogActivityInNativeMode; |
There was a problem hiding this comment.
Is this really a native mode only option?
There was a problem hiding this comment.
Yes, we had to replace the dns lookup in native (via substitutions), because it was using jndi. I replaced it with some vertx code. However, dns lookup is sometimes close to rocket science, and to understand what's going on, we may need the dns frames.
There was a problem hiding this comment.
Thanks for the information!
So even if set in JVM mode, no logging information would be displayed?
There was a problem hiding this comment.
No, in JVM it uses ... JNDI. Nothing we can do, the Mongo client does not allow changing this default behavior.
geoand
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #23548
NOTE: I was unable to test against a serverless instance.