Execute gRPC request processing on duplicated contexts #23607
Conversation
extensions/grpc/deployment/src/test/java/io/quarkus/grpc/server/services/AssertHelper.java
Show resolved
Hide resolved
| @@ -32,13 +36,15 @@ | |||
| public Uni<EmptyProtos.Empty> emptyCallBlocking(EmptyProtos.Empty request) { | |||
| assertThat(request).isNotNull(); | |||
| assertRunOnWorker(); | |||
| assertRunOnDuplicatedContext(); | |||
There was a problem hiding this comment.
I'm a bit surprised that not being on the event loop we still have a vertx context
There was a problem hiding this comment.
Yes, I know it's confusing. But inside an "executeBlocking" block, you still have access to the same context as outside (leading to fun concurrency issue)
There was a problem hiding this comment.
does it work for the root contexts too? Or only duplicated ones?
There was a problem hiding this comment.
it also works from the root context too, but more like a side effect of the implementation of the executeBlocking.
This is actually why, inside an executeBlocking block, if you ask vert.x is the context is an event loop context, it will return true (while you are not running on the event loop).
...ntime/src/main/java/io/quarkus/grpc/runtime/supports/blocking/BlockingServerInterceptor.java
Outdated
Show resolved
Hide resolved
cescoffier
force-pushed
the
grpc-server-duplicated-context
branch
from
d773247 to
aeec9af
Compare
No description provided.