Update Security NVD doc section #23624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loicmathieu
approved these changes
Feb 14, 2022
There was a problem hiding this comment.
LGTM, 2 minor typos.
Such a suppression list has to be carefully prepared and sometimes it can be disabled to doublecheck that only the same known false positives are reported.
I never disabled it but you can add a duration (untill parameter) for your suppressions. Here it's only false positive at CPE level wich should be pretty stable but yes, a sentence may be added that state that suppression list must be handled carefully and revisited from time to time.
|
@loicmathieu Thanks, let me add a note about the time limited suppression |
sberyozkin
force-pushed
the
update_security_nvd_doc
branch
from
4a48568 to
06208db
Compare
|
@loicmathieu I replaced the proposal to disable with the suggestion to consider adding an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23476.
Hi Loic - can you check it please, I added the example how it can be configured based on your feedback at #23476.
I've added a recommendation to disable the suppression list sometimes, such as to check that no real issues have happened in the suppressed dependencies, do you agree ?