Add support for `java.util.Map` to `ConfigInstantiator` #23652

famod · 2022-02-13T20:43:54Z

The main motivation is to pick up log category level config when running a simple unit test (see also latest enhancements to BasicLoggingEnabler: #23628).

This is in draft mode for now because the following test fails with twice the number of handlers than expected:
https://github.com/quarkusio/quarkus/blob/main/core/test-extension/deployment/src/test/java/io/quarkus/logging/CategoryConfiguredHandlerTest.java#L41-L42

For that I added a quickfix which surely isn't going to be merged like this. I'll add a comment so we can discuss this specifically.

famod · 2022-02-13T20:54:33Z

core/deployment/src/main/java/io/quarkus/deployment/logging/LoggingResourceProcessor.java

@@ -209,6 +209,7 @@ LoggingSetupBuildItem setupLoggingRuntimeInit(LoggingSetupRecorder recorder, Log
                    possibleSupplier, launchModeBuildItem.getLaunchMode());
            LogConfig logConfig = new LogConfig();
            ConfigInstantiator.handleObject(logConfig);
+            logConfig.categories.clear(); // FIXME: workaround for duplicate handlers in CategoryConfiguredHandlerTest:42


@stuartwdouglas @geoand this where I need some help:
The call on the previous line will now also provide category config (as expected). This makes the test fail because it only expects one ConsoleHandler and one FileHandler, not two of each.

I must say I'm very confused why LogConfig is recreated here (it's already fully available to this method via log, e.g. it's passed to recorder.initializeLogging() on line 206).
I also fail to understand how LoggingSetupRecorder.initializeBuildTimeLogging() (called further down) was ever able to handle category config:

quarkus/core/runtime/src/main/java/io/quarkus/runtime/logging/LoggingSetupRecorder.java

Line 263 in 2b44967

for (Map.Entry<String, CategoryConfig> entry : categories.entrySet()) {

I mean, before my change Maps weren't even evaluated/populated...?

I'm less than sure what's the right approach here. Is the test to be adjusted? But aren't duplicated handlers a problem indeed?

I think you need to add a clearHandlers() call to io.quarkus.bootstrap.logging.QuarkusDelayedHandler#buildTimeComplete.

The reason why LogConfig is created here is because it is runtime config, and this is a build time method. It's kinda hacky, but we basically just use whatever the current config would be to initialize build time logging (just so we don't have to duplicate all logging config into a new build time config).

To be honest, I can't say I know the reason either

@stuartwdouglas can you shed some light on this?

I think you need to add a clearHandlers() call to io.quarkus.bootstrap.logging.QuarkusDelayedHandler#buildTimeComplete.

Makes sense and it does work! Thanks!

The reason why LogConfig is created here is because it is runtime config, and this is a build time method. It's kinda hacky, but we basically just use whatever the current config would be to initialize build time logging (just so we don't have to duplicate all logging config into a new build time config).

Ok, so LogConfig log passed to this method is not to be confused with LogConfig logConfig?

core/runtime/pom.xml

core/runtime/src/main/java/io/quarkus/runtime/configuration/ConfigInstantiator.java

famod · 2022-02-13T20:59:19Z

core/runtime/src/main/java/io/quarkus/runtime/configuration/ConfigInstantiator.java

+            return map;
+        }
+        var processedSegments = new HashSet<String>();
+        // infer the map keys from existing property names


So I'm extracting the segments/map keys from all present property names.

At this point I have no idea whether or not this covers env var flavors (e.g. QUARKUS_FOO).

...jects/bootstrap/runner/src/main/java/io/quarkus/bootstrap/logging/QuarkusDelayedHandler.java

stuartwdouglas

Oops, looks like I left my comments on pending.

core/runtime/pom.xml

...jects/bootstrap/runner/src/main/java/io/quarkus/bootstrap/logging/QuarkusDelayedHandler.java

stuartwdouglas · 2022-02-14T01:08:53Z

core/deployment/src/main/java/io/quarkus/deployment/logging/LoggingResourceProcessor.java

@@ -209,6 +209,7 @@ LoggingSetupBuildItem setupLoggingRuntimeInit(LoggingSetupRecorder recorder, Log
                    possibleSupplier, launchModeBuildItem.getLaunchMode());
            LogConfig logConfig = new LogConfig();
            ConfigInstantiator.handleObject(logConfig);
+            logConfig.categories.clear(); // FIXME: workaround for duplicate handlers in CategoryConfiguredHandlerTest:42


I think you need to add a clearHandlers() call to io.quarkus.bootstrap.logging.QuarkusDelayedHandler#buildTimeComplete.

stuartwdouglas · 2022-02-14T01:10:07Z

core/deployment/src/main/java/io/quarkus/deployment/logging/LoggingResourceProcessor.java

@@ -209,6 +209,7 @@ LoggingSetupBuildItem setupLoggingRuntimeInit(LoggingSetupRecorder recorder, Log
                    possibleSupplier, launchModeBuildItem.getLaunchMode());
            LogConfig logConfig = new LogConfig();
            ConfigInstantiator.handleObject(logConfig);
+            logConfig.categories.clear(); // FIXME: workaround for duplicate handlers in CategoryConfiguredHandlerTest:42


The reason why LogConfig is created here is because it is runtime config, and this is a build time method. It's kinda hacky, but we basically just use whatever the current config would be to initialize build time logging (just so we don't have to duplicate all logging config into a new build time config).

famod · 2022-02-14T23:32:14Z

I'm adding the backport label because I kind of "advertised" to users that logging in Unit tests now works in 2.7 and it's unexpected that it won't pick up category config (before this PR).

quarkus-bot · 2022-02-15T04:19:56Z

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building `5781722`

Status	Name	Step	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs
✖	JVM Tests - JDK 17	`Build`	Failures	Logs	Raw logs
✖	Maven Tests - JDK 11	`Build`	Failures	Logs	Raw logs
✖	Maven Tests - JDK 11 Windows	`Build`	Failures	Logs	Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/kotlin integration-tests/picocli-native integration-tests/scala

📦 integration-tests/kotlin

✖ io.quarkus.kotlin.maven.it.KotlinRemoteDevModeIT.testThatTheApplicationIsReloadedOnKotlinChange line 25 - More details - Source on GitHub

java.lang.RuntimeException: org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase.runAndCheck(RunAndCheckWithAgentMojoTestBase.java:83)
	at io.quarkus.kotlin.maven.it.KotlinRemoteDevModeIT.testThatTheApplicationIsReloadedOnKotlinChange(KotlinRemoteDevModeIT.java:25)

📦 integration-tests/picocli-native

✖ io.quarkus.it.picocli.PicocliTest.testIncludeLogCommand(QuarkusMainLauncher) line 51 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

📦 integration-tests/scala

✖ io.quarkus.scala.maven.it.ScalaRemoteDevModeIT.testThatTheApplicationIsReloadedOnScalaChange line 25 - More details - Source on GitHub

java.lang.RuntimeException: org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase.runAndCheck(RunAndCheckWithAgentMojoTestBase.java:83)
	at io.quarkus.scala.maven.it.ScalaRemoteDevModeIT.testThatTheApplicationIsReloadedOnScalaChange(ScalaRemoteDevModeIT.java:25)

⚙️ JVM Tests - JDK 11 Windows #

- Failing: integration-tests/kotlin integration-tests/picocli-native integration-tests/scala

📦 integration-tests/kotlin

✖ io.quarkus.kotlin.maven.it.KotlinRemoteDevModeIT.testThatTheApplicationIsReloadedOnKotlinChange line 25 - More details - Source on GitHub

java.lang.RuntimeException: org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase.runAndCheck(RunAndCheckWithAgentMojoTestBase.java:83)
	at io.quarkus.kotlin.maven.it.KotlinRemoteDevModeIT.testThatTheApplicationIsReloadedOnKotlinChange(KotlinRemoteDevModeIT.java:25)

📦 integration-tests/picocli-native

✖ io.quarkus.it.picocli.PicocliTest.testIncludeLogCommand(QuarkusMainLauncher) line 51 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

📦 integration-tests/scala

✖ io.quarkus.scala.maven.it.ScalaRemoteDevModeIT.testThatTheApplicationIsReloadedOnScalaChange line 25 - More details - Source on GitHub

java.lang.RuntimeException: org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase.runAndCheck(RunAndCheckWithAgentMojoTestBase.java:83)
	at io.quarkus.scala.maven.it.ScalaRemoteDevModeIT.testThatTheApplicationIsReloadedOnScalaChange(ScalaRemoteDevModeIT.java:25)

⚙️ JVM Tests - JDK 17 #

- Failing: integration-tests/kotlin integration-tests/picocli-native integration-tests/scala

📦 integration-tests/kotlin

✖ io.quarkus.kotlin.maven.it.KotlinRemoteDevModeIT.testThatTheApplicationIsReloadedOnKotlinChange line 25 - More details - Source on GitHub

java.lang.RuntimeException: org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase.runAndCheck(RunAndCheckWithAgentMojoTestBase.java:83)
	at io.quarkus.kotlin.maven.it.KotlinRemoteDevModeIT.testThatTheApplicationIsReloadedOnKotlinChange(KotlinRemoteDevModeIT.java:25)

📦 integration-tests/picocli-native

✖ io.quarkus.it.picocli.PicocliTest.testIncludeLogCommand(QuarkusMainLauncher) line 51 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

📦 integration-tests/scala

✖ io.quarkus.scala.maven.it.ScalaRemoteDevModeIT.testThatTheApplicationIsReloadedOnScalaChange line 25 - More details - Source on GitHub

java.lang.RuntimeException: org.awaitility.core.ConditionTimeoutException: Condition with io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase.runAndCheck(RunAndCheckWithAgentMojoTestBase.java:83)
	at io.quarkus.scala.maven.it.ScalaRemoteDevModeIT.testThatTheApplicationIsReloadedOnScalaChange(ScalaRemoteDevModeIT.java:25)

⚙️ Maven Tests - JDK 11 #

- Failing: integration-tests/maven

📦 integration-tests/maven

✖ io.quarkus.maven.it.RemoteDevMojoIT.testThatApplicationRecoversCompilationIssue line 164 - More details - Source on GitHub

java.lang.RuntimeException: org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase.runAndCheck(RunAndCheckWithAgentMojoTestBase.java:83)
	at io.quarkus.maven.it.RemoteDevMojoIT.testThatApplicationRecoversCompilationIssue(RemoteDevMojoIT.java:164)

✖ io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnNewResource line 66 - More details - Source on GitHub

java.lang.RuntimeException: org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase.runAndCheck(RunAndCheckWithAgentMojoTestBase.java:83)
	at io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnNewResource(RemoteDevMojoIT.java:66)

✖ io.quarkus.maven.it.RemoteDevMojoIT.testThatNewBeanAreDiscovered line 201 - More details - Source on GitHub

java.lang.RuntimeException: org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase.runAndCheck(RunAndCheckWithAgentMojoTestBase.java:83)
	at io.quarkus.maven.it.RemoteDevMojoIT.testThatNewBeanAreDiscovered(RemoteDevMojoIT.java:201)

✖ io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnConfigChange line 98 - More details - Source on GitHub

java.lang.RuntimeException: org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase.runAndCheck(RunAndCheckWithAgentMojoTestBase.java:83)
	at io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnConfigChange(RemoteDevMojoIT.java:98)

✖ io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnJavaChange line 34 - More details - Source on GitHub

java.lang.RuntimeException: org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase.runAndCheck(RunAndCheckWithAgentMojoTestBase.java:83)
	at io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnJavaChange(RemoteDevMojoIT.java:34)

✖ io.quarkus.maven.it.RemoteDevMojoIT.testThatApplicationRecoversCompilationIssue line 164 - More details - Source on GitHub

java.lang.RuntimeException: org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase.runAndCheck(RunAndCheckWithAgentMojoTestBase.java:83)
	at io.quarkus.maven.it.RemoteDevMojoIT.testThatApplicationRecoversCompilationIssue(RemoteDevMojoIT.java:164)

✖ io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnNewResource line 66 - More details - Source on GitHub

java.lang.RuntimeException: org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase.runAndCheck(RunAndCheckWithAgentMojoTestBase.java:83)
	at io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnNewResource(RemoteDevMojoIT.java:66)

✖ io.quarkus.maven.it.RemoteDevMojoIT.testThatNewBeanAreDiscovered line 201 - More details - Source on GitHub

java.lang.RuntimeException: org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase.runAndCheck(RunAndCheckWithAgentMojoTestBase.java:83)
	at io.quarkus.maven.it.RemoteDevMojoIT.testThatNewBeanAreDiscovered(RemoteDevMojoIT.java:201)

✖ io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnConfigChange line 98 - More details - Source on GitHub

java.lang.RuntimeException: org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase.runAndCheck(RunAndCheckWithAgentMojoTestBase.java:83)
	at io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnConfigChange(RemoteDevMojoIT.java:98)

✖ io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnJavaChange line 34 - More details - Source on GitHub

java.lang.RuntimeException: org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase.runAndCheck(RunAndCheckWithAgentMojoTestBase.java:83)
	at io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnJavaChange(RemoteDevMojoIT.java:34)

⚙️ Maven Tests - JDK 11 Windows #

- Failing: integration-tests/maven

📦 integration-tests/maven

✖ io.quarkus.maven.it.RemoteDevMojoIT.testThatApplicationRecoversCompilationIssue line 164 - More details - Source on GitHub

java.lang.RuntimeException: org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase.runAndCheck(RunAndCheckWithAgentMojoTestBase.java:83)
	at io.quarkus.maven.it.RemoteDevMojoIT.testThatApplicationRecoversCompilationIssue(RemoteDevMojoIT.java:164)

✖ io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnNewResource line 66 - More details - Source on GitHub

java.lang.RuntimeException: org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase.runAndCheck(RunAndCheckWithAgentMojoTestBase.java:83)
	at io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnNewResource(RemoteDevMojoIT.java:66)

✖ io.quarkus.maven.it.RemoteDevMojoIT.testThatNewBeanAreDiscovered line 201 - More details - Source on GitHub

java.lang.RuntimeException: org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase.runAndCheck(RunAndCheckWithAgentMojoTestBase.java:83)
	at io.quarkus.maven.it.RemoteDevMojoIT.testThatNewBeanAreDiscovered(RemoteDevMojoIT.java:201)

✖ io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnConfigChange line 98 - More details - Source on GitHub

java.lang.RuntimeException: org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase.runAndCheck(RunAndCheckWithAgentMojoTestBase.java:83)
	at io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnConfigChange(RemoteDevMojoIT.java:98)

✖ io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnJavaChange line 34 - More details - Source on GitHub

java.lang.RuntimeException: org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase.runAndCheck(RunAndCheckWithAgentMojoTestBase.java:83)
	at io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnJavaChange(RemoteDevMojoIT.java:34)

✖ io.quarkus.maven.it.RemoteDevMojoIT.testThatApplicationRecoversCompilationIssue line 164 - More details - Source on GitHub

java.lang.RuntimeException: org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase.runAndCheck(RunAndCheckWithAgentMojoTestBase.java:83)
	at io.quarkus.maven.it.RemoteDevMojoIT.testThatApplicationRecoversCompilationIssue(RemoteDevMojoIT.java:164)

✖ io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnNewResource line 66 - More details - Source on GitHub

java.lang.RuntimeException: org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase.runAndCheck(RunAndCheckWithAgentMojoTestBase.java:83)
	at io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnNewResource(RemoteDevMojoIT.java:66)

✖ io.quarkus.maven.it.RemoteDevMojoIT.testThatNewBeanAreDiscovered line 201 - More details - Source on GitHub

java.lang.RuntimeException: org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase.runAndCheck(RunAndCheckWithAgentMojoTestBase.java:83)
	at io.quarkus.maven.it.RemoteDevMojoIT.testThatNewBeanAreDiscovered(RemoteDevMojoIT.java:201)

✖ io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnConfigChange line 98 - More details - Source on GitHub

java.lang.RuntimeException: org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase.runAndCheck(RunAndCheckWithAgentMojoTestBase.java:83)
	at io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnConfigChange(RemoteDevMojoIT.java:98)

✖ io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnJavaChange line 34 - More details - Source on GitHub

java.lang.RuntimeException: org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase.runAndCheck(RunAndCheckWithAgentMojoTestBase.java:83)
	at io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnJavaChange(RemoteDevMojoIT.java:34)

famod · 2022-02-15T22:48:30Z

I need to have a closer look at those test failures. I guess that clearHandlers() call has broken something for them.

famod · 2022-02-19T00:02:14Z

...jects/bootstrap/runner/src/main/java/io/quarkus/bootstrap/logging/QuarkusDelayedHandler.java

@@ -207,6 +207,7 @@ public void addLoggingCloseTask(Runnable runnable) {

    public synchronized void buildTimeComplete() {
        buildTimeLoggingActivated = false;
+        runCloseTasks();


Turns out that calling clearHandlers() breaks a couple of tests that try to capture log output (see #23652 (comment)).
Just running the close tasks instead is the "middle ground" that seems to work for all tests. Let's see what CI has to say...

famod requested review from stuartwdouglas and geoand February 13, 2022 20:43

quarkus-bot bot added area/config area/core area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins labels Feb 13, 2022

famod commented Feb 13, 2022

View reviewed changes

core/runtime/pom.xml Show resolved Hide resolved

famod commented Feb 13, 2022

View reviewed changes

core/runtime/src/main/java/io/quarkus/runtime/configuration/ConfigInstantiator.java Show resolved Hide resolved

famod commented Feb 13, 2022

View reviewed changes

...jects/bootstrap/runner/src/main/java/io/quarkus/bootstrap/logging/QuarkusDelayedHandler.java Outdated Show resolved Hide resolved

stuartwdouglas reviewed Feb 14, 2022

View reviewed changes

famod marked this pull request as ready for review February 14, 2022 23:30

famod requested a review from stuartwdouglas February 14, 2022 23:30

famod added the triage/backport? label Feb 14, 2022

quarkusio deleted a comment from quarkus-bot bot Feb 14, 2022

stuartwdouglas approved these changes Feb 15, 2022

View reviewed changes

Add support for java.util.Map to ConfigInstantiator

2267eca

famod commented Feb 19, 2022

View reviewed changes

famod merged commit 9f5c1c1 into quarkusio:main Feb 19, 2022

quarkus-bot bot added this to the 2.8 - main milestone Feb 19, 2022

famod deleted the ConfigInstantiator-maps branch February 19, 2022 09:28

gsmet modified the milestones: 2.8 - main, 2.7.2.Final Feb 21, 2022

gsmet removed the triage/backport? label Feb 21, 2022

famod mentioned this pull request Mar 21, 2022

JBoss Threads version logging in tests #24283

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for `java.util.Map` to `ConfigInstantiator` #23652

Add support for `java.util.Map` to `ConfigInstantiator` #23652

famod commented Feb 13, 2022

famod Feb 13, 2022 •

edited

Loading

stuartwdouglas Feb 14, 2022

stuartwdouglas Feb 14, 2022

geoand Feb 14, 2022

famod Feb 14, 2022

famod Feb 14, 2022

famod Feb 13, 2022 •

edited

Loading

stuartwdouglas left a comment

stuartwdouglas Feb 14, 2022

stuartwdouglas Feb 14, 2022

famod commented Feb 14, 2022

quarkus-bot bot commented Feb 15, 2022 •

edited

Loading

Failing Jobs - Building `5781722`

Failures

⚙️ JVM Tests - JDK 11 #

📦 integration-tests/kotlin

📦 integration-tests/picocli-native

📦 integration-tests/scala

⚙️ JVM Tests - JDK 11 Windows #

📦 integration-tests/kotlin

📦 integration-tests/picocli-native

📦 integration-tests/scala

⚙️ JVM Tests - JDK 17 #

📦 integration-tests/kotlin

📦 integration-tests/picocli-native

📦 integration-tests/scala

⚙️ Maven Tests - JDK 11 #

📦 integration-tests/maven

⚙️ Maven Tests - JDK 11 Windows #

📦 integration-tests/maven

famod commented Feb 15, 2022 •

edited

Loading

famod Feb 19, 2022

Add support for java.util.Map to ConfigInstantiator #23652

Add support for java.util.Map to ConfigInstantiator #23652

Conversation

famod commented Feb 13, 2022

famod Feb 13, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

famod Feb 13, 2022 • edited Loading

Choose a reason for hiding this comment

stuartwdouglas left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

famod commented Feb 14, 2022

quarkus-bot bot commented Feb 15, 2022 • edited Loading

Failing Jobs - Building 5781722

Failures

⚙️ JVM Tests - JDK 11 #

📦 integration-tests/kotlin

📦 integration-tests/picocli-native

📦 integration-tests/scala

⚙️ JVM Tests - JDK 11 Windows #

📦 integration-tests/kotlin

📦 integration-tests/picocli-native

📦 integration-tests/scala

⚙️ JVM Tests - JDK 17 #

📦 integration-tests/kotlin

📦 integration-tests/picocli-native

📦 integration-tests/scala

⚙️ Maven Tests - JDK 11 #

📦 integration-tests/maven

⚙️ Maven Tests - JDK 11 Windows #

📦 integration-tests/maven

famod commented Feb 15, 2022 • edited Loading

Choose a reason for hiding this comment

Add support for `java.util.Map` to `ConfigInstantiator` #23652

Add support for `java.util.Map` to `ConfigInstantiator` #23652

famod Feb 13, 2022 •

edited

Loading

famod Feb 13, 2022 •

edited

Loading

quarkus-bot bot commented Feb 15, 2022 •

edited

Loading

Failing Jobs - Building `5781722`

famod commented Feb 15, 2022 •

edited

Loading