Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore if stdin wasn't initialized yet #23675

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Ignore if stdin wasn't initialized yet #23675

merged 1 commit into from
Feb 14, 2022

Conversation

gastaldi
Copy link
Contributor

Fixes #23674

@geoand
Copy link
Contributor

geoand commented Feb 14, 2022

I'll leave this one to Stuart as I have no idea what the implications are

@gastaldi
Copy link
Contributor Author

I'll leave this one to Stuart as I have no idea what the implications are

Sure, if you look at the stacktrace in the issue referenced here, you'll see that if the stdin is null, it will cause a NPE down below

@geoand
Copy link
Contributor

geoand commented Feb 14, 2022

Just want to make sure that returning here doesn't break something else

@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 14, 2022
@famod famod merged commit b50232c into quarkusio:main Feb 14, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Feb 14, 2022
@quarkus-bot quarkus-bot bot added kind/bugfix and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Feb 14, 2022
@gsmet gsmet modified the milestones: 2.8 - main, 2.7.2.Final Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DevUI console no longer responds if you enter input before it boots
5 participants