Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RestClientListener discovery for Reactive REST Client #23721

Merged

Conversation

pravussum
Copy link
Contributor

Fixes #23718

@quarkus-bot
Copy link

quarkus-bot bot commented Feb 15, 2022

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@geoand geoand changed the title [rest-client-reactive] Fix RestClientListener discovery Fix RestClientListener discovery for Reactive REST Client Feb 15, 2022
@geoand
Copy link
Contributor

geoand commented Feb 15, 2022

Thanks for this!

Any chance we can get a test for this?

@pravussum pravussum force-pushed the fix-reactive-rest-client-listeners-discovery branch from e8ac398 to 1545894 Compare February 16, 2022 09:06
@pravussum
Copy link
Contributor Author

I added a test & rebased on the current main.

Copy link
Contributor

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@michalszynkiewicz
Copy link
Member

@geoand I think you know Quarkus class loading better than me, if you say not passing the classloader to the service loader is better, let's merge it :)

@geoand
Copy link
Contributor

geoand commented Feb 16, 2022

Well, when we don't pass the ClassLoader, the JDK uses the TCCL, which is what we want :)

@geoand geoand merged commit d840d72 into quarkusio:main Feb 16, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Feb 16, 2022
@gsmet gsmet modified the milestones: 2.8 - main, 2.7.2.Final Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[rest-client-reactive] RestClientListener is not called
4 participants