Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use thread safe list #23824

Merged
merged 1 commit into from
Feb 21, 2022
Merged

Use thread safe list #23824

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ...ration-tests/grpc-hibernate/src/test/java/com/example/grpc/hibernate/BlockingRawTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import java.time.Duration;
import java.util.ArrayList;
import java.util.List;
import java.util.concurrent.CopyOnWriteArrayList;

import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Timeout;
Expand Down Expand Up @@ -49,7 +50,7 @@ void shouldAdd() {
.await().atMost(Duration.ofSeconds(5));
}

List<String> actual = new ArrayList<>();
List<String> actual = new CopyOnWriteArrayList<>();
Multi<TestOuterClass.Item> all = client.getAll(EMPTY)
.onFailure().invoke(th -> {
System.out.println("Failed to read");
Expand All @@ -65,8 +66,8 @@ void shouldAdd() {
@Timeout(TIMEOUT)
void shouldAddViaBidi() {
List<String> expected = new ArrayList<>();
List<String> echoed = new ArrayList<>();
List<String> actual = new ArrayList<>();
List<String> echoed = new CopyOnWriteArrayList<>();
List<String> actual = new CopyOnWriteArrayList<>();

Multi<TestOuterClass.Item> request = Multi.createFrom().emitter(
m -> {
Expand Down