Fix project and scm urls in child project POMs

[lucifer4j]

Maven's default behaviour is to append path and artifact id to parent project url for setting child project's url. But this is not helpful because these urls, for instance https://github.com/quarkusio/quarkus/bom/quarkus-bom end up in 404s. Similarly, the scm urls are broken. The right behaviour would most likely be to point to just https://github.com/quarkusio/quarkus/.

Thankfully, Maven 3.6.1 introduced some attribute to set the child project's url to the project url of the parent without modifications. Therefore, set the child.project.url.inherit.append.path project attribute and various scm attributes to ensure the correct urls are generated.

The fix can be verified by running help:effective-pom maven goal and looking at the output.

[gastaldi]

LGTM

[gastaldi]

@lucifer4j do you have a reference link to share showing these properties?

[quarkus-bot]

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 585000e

Status	Name	Step	Failures	Logs	Raw logs
✖	Gradle Tests - JDK 11 Windows	Build	Failures	Logs	Raw logs
✖	JVM Tests - JDK 11	Build	Failures	Logs	Raw logs
✔️	JVM Tests - JDK 17

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle 

📦 integration-tests/gradle

✖ io.quarkus.gradle.devmode.DotEnvQuarkusDevModeConfigurationTest.main line 13 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in io.quarkus.test.devmode.util.DevModeTestUtils that uses java.util.function.Supplier, java.util.function.Supplierjava.util.concurrent.atomic.AtomicReference, java.util.concurrent.atomic.AtomicReferencejava.lang.String, java.lang.Stringboolean was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

---

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/grpc-hibernate 

📦 integration-tests/grpc-hibernate

✖ com.example.grpc.hibernate.BlockingRawTest.shouldAdd line 61 - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with lambda expression in com.example.grpc.hibernate.BlockingRawTest that uses java.util.List was not fulfilled within 30 seconds.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:164)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)

[lucifer4j]

@gastaldi Ah yes. Sorry forgot to put it here earlier. Here it is: Maven POM schema reference. Anchors are not available on the page so you may need to scroll a bit to find the attributes. These are the attributes to look for: child.project.url.inherit.append.path, child.scm.connection.inherit.append.path, child.scm.developerConnection.inherit.append.path and child.scm.url.inherit.append.path.

There is also 1 additional attribute available child.site.url.inherit.append.path. I didn't see the site url to be specified anywhere in the parent pom, the pom in docs or in the quick search of the pom files in the repo so I didn't use that attribute in the PR.

[famod]

Can't say I have used those myself, but looks alright!

But I think independent-projects should be covered as well?

[lucifer4j]

Hi! Sorry for the delay in replying. @famod I have updated independent projects as well. Since the independent projects inherit from JBoss Parent POM, I also needed to add url and scm at a few places in the parent independent projects. Otherwise, the url would have been set to the jboss repo.

[lucifer4j]

I realised a few minutes ago that the jboss-parent-pom is probably a better place to fix this issue so I have opened a PR there. If that PR gets accepted, this one can probably be discarded.

[famod]

I realised a few minutes ago that the jboss-parent-pom is probably a better place to fix this issue so I have opened a PR there. If that PR gets accepted, this one can probably be discarded.

Thanks! But I think we should merge this regardless as things are moving very slow for jboss-parent.

[gastaldi]

Oops, clicked the Update Branch by accident, should have chosen Rebase

[lucifer4j]

@famod Oh! Makes sense 👍