Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Arc NPE if quarkus.arc.remove-unused-beans is false #23946

Merged
merged 1 commit into from
Feb 24, 2022

Conversation

radcortez
Copy link
Member

@radcortez radcortez commented Feb 24, 2022

If quarkus.arc.remove-unused-beans is false, it originates NPEs when retrieving the removed interceptors / decorators (because they were never added to the context)

@quarkus-bot quarkus-bot bot added area/arc Issue related to ARC (dependency injection) area/vertx labels Feb 24, 2022
@radcortez radcortez requested a review from mkouba February 24, 2022 14:28
@radcortez radcortez changed the title Fix possible Arc NPE if quarkus.arc.remove-unused-beans is false Fix Arc NPE if quarkus.arc.remove-unused-beans is false Feb 24, 2022
@mkouba
Copy link
Contributor

mkouba commented Feb 24, 2022

@gsmet I think that this PR does not have to be backported because it only affects the main branch.

@mkouba mkouba added triage/waiting-for-ci Ready to merge when CI successfully finishes and removed area/vertx triage/backport? labels Feb 24, 2022
@mkouba
Copy link
Contributor

mkouba commented Feb 24, 2022

@radcortez Thanks for spotting this! ;-)

@radcortez
Copy link
Member Author

@radcortez Thanks for spotting this! ;-)

Got lucky. I was trying the main build on an app that had that disabled :)

@geoand geoand merged commit ed30044 into quarkusio:main Feb 24, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Feb 24, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 24, 2022
@radcortez radcortez deleted the fix-arc-npe branch December 16, 2022 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants