Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close opened ZipFileSystems during generate-code goal execution #24018

Closed
wants to merge 1 commit into from

Conversation

Postremus
Copy link
Member

@Postremus Postremus commented Feb 28, 2022

This will close all opened zip file systems of dependencies. These files where still locked during mojo execution by m2e, since the mojo is never destroyed.

This is basicly the same way the gradle plugin does it already.
https://github.com/quarkusio/quarkus/blob/main/devtools/gradle/gradle-application-plugin/src/main/java/io/quarkus/gradle/tasks/QuarkusGenerateCode.java#L97

Fixes #23655

This will close all opened zip file systems of dependencies. These files where still locked during mojo execution by m2e, since the mojo is never destroyed.
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 28, 2022

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

  • title should preferably start with an uppercase character (if it makes sense!)

This message is automatically generated by a bot.

@quarkus-bot quarkus-bot bot added area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven labels Feb 28, 2022
@Postremus Postremus changed the title close created CuratedApplication Close created CuratedApplication Feb 28, 2022
@Postremus Postremus changed the title Close created CuratedApplication Close opened ZipFileSystems during generate-code goal execution. Feb 28, 2022
@Postremus Postremus changed the title Close opened ZipFileSystems during generate-code goal execution. Close opened ZipFileSystems during generate-code goal execution Feb 28, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 28, 2022

Failing Jobs - Building aa7012d

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
JVM Tests - JDK 11 Windows Build Failures Logs Raw logs
JVM Tests - JDK 17 Build Failures Logs Raw logs
Native Tests - Messaging1 Download Maven Repo ⚠️ Check → Logs Raw logs
Native Tests - gRPC Build Failures Logs Raw logs

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/grpc-plain-text-gzip 

📦 integration-tests/grpc-plain-text-gzip

Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project quarkus-integration-test-grpc-plain-text-gzip: Failed to build quarkus application


⚙️ JVM Tests - JDK 11 Windows #

- Failing: integration-tests/grpc-plain-text-gzip 

📦 integration-tests/grpc-plain-text-gzip

Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project quarkus-integration-test-grpc-plain-text-gzip: Failed to build quarkus application


⚙️ JVM Tests - JDK 17 #

- Failing: integration-tests/grpc-plain-text-gzip 

📦 integration-tests/grpc-plain-text-gzip

Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project quarkus-integration-test-grpc-plain-text-gzip: Failed to build quarkus application


⚙️ Native Tests - gRPC #

- Failing: integration-tests/grpc-plain-text-gzip 

📦 integration-tests/grpc-plain-text-gzip

Failed to execute goal io.quarkus:quarkus-maven-plugin:999-SNAPSHOT:build (default) on project quarkus-integration-test-grpc-plain-text-gzip: Failed to build quarkus application

@gsmet
Copy link
Member

gsmet commented Feb 28, 2022

The test failures look fishy to me.

@Postremus
Copy link
Member Author

Postremus commented Mar 1, 2022

I can reproduce these failures localy.
A simple mvn quarkus:generate-code quarkus:build reproduces the NPE, while mvn quarkus:build or mvn quarkus:generate-code alone do not.

I believe there might be a leak somewhere, or something else needs to be closed first. (I.e. the quarkus classloader).
I will look into this now.

@aloubyansky
Copy link
Member

This would make every mojo bootstrap its own instance of the app. Before we do this, let's make sure we can't do better than that. For example #24026

@Postremus
Copy link
Member Author

Closing in favor of #24026

@Postremus Postremus closed this Mar 1, 2022
@quarkus-bot quarkus-bot bot added triage/invalid This doesn't seem right and removed triage/backport? labels Mar 1, 2022
rsvoboda added a commit to rsvoboda/beefy-scenarios that referenced this pull request Mar 1, 2022
Sort of breaking change introduced in quarkusio/quarkus#24018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/maven triage/invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eclipse Maven Update "Too Many Files" with 2.7.1
3 participants