-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close opened ZipFileSystems during generate-code goal execution #24018
Conversation
This will close all opened zip file systems of dependencies. These files where still locked during mojo execution by m2e, since the mojo is never destroyed.
Thanks for your pull request! The title of your pull request does not follow our editorial rules. Could you have a look?
|
Failing Jobs - Building aa7012d
Failures⚙️ JVM Tests - JDK 11 #- Failing: integration-tests/grpc-plain-text-gzip
📦 integration-tests/grpc-plain-text-gzip✖ ⚙️ JVM Tests - JDK 11 Windows #- Failing: integration-tests/grpc-plain-text-gzip
📦 integration-tests/grpc-plain-text-gzip✖ ⚙️ JVM Tests - JDK 17 #- Failing: integration-tests/grpc-plain-text-gzip
📦 integration-tests/grpc-plain-text-gzip✖ ⚙️ Native Tests - gRPC #- Failing: integration-tests/grpc-plain-text-gzip
📦 integration-tests/grpc-plain-text-gzip✖ |
The test failures look fishy to me. |
I can reproduce these failures localy. I believe there might be a leak somewhere, or something else needs to be closed first. (I.e. the quarkus classloader). |
This would make every mojo bootstrap its own instance of the app. Before we do this, let's make sure we can't do better than that. For example #24026 |
Closing in favor of #24026 |
Sort of breaking change introduced in quarkusio/quarkus#24018
This will close all opened zip file systems of dependencies. These files where still locked during mojo execution by m2e, since the mojo is never destroyed.
This is basicly the same way the gradle plugin does it already.
https://github.com/quarkusio/quarkus/blob/main/devtools/gradle/gradle-application-plugin/src/main/java/io/quarkus/gradle/tasks/QuarkusGenerateCode.java#L97
Fixes #23655