Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rectify bad class formats in some cases #24106

Merged
merged 1 commit into from
Mar 4, 2022
Merged

Rectify bad class formats in some cases #24106

merged 1 commit into from
Mar 4, 2022

Conversation

evanchooly
Copy link
Member

fixes #23727

The checks were a little too defensive coupled with a little too naive and, in practice, ultimately unnecessary as it turns out.

loicmathieu
loicmathieu approved these changes Mar 4, 2022
View reviewed changes
Copy link
Contributor

@loicmathieu loicmathieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evanchooly evanchooly merged commit e1a7973 into quarkusio:main Mar 4, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Mar 4, 2022
@evanchooly evanchooly deleted the badClassFormat branch March 4, 2022 18:27
@gsmet gsmet modified the milestones: 2.8 - main, 2.7.4.Final Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loicmathieu loicmathieu loicmathieu approved these changes

@FroMage FroMage Awaiting requested review from FroMage

Assignees
No one assigned
Labels
area/panache kind/bugfix
Projects
None yet
Milestone
2.7.4.Final
Development

Successfully merging this pull request may close these issues.

Odd class format error
3 participants
@evanchooly @loicmathieu @gsmet