Do not create new instances in nested tests

[Sgitario]

Fix #23947
Fix #20114

[quarkus-bot]

Thanks for your pull request!

The title of your pull request does not follow our editorial rules. Could you have a look?

• title should preferably start with an uppercase character (if it makes sense!)
• title should not start with chore/docs/feat/fix/refactor but be a proper sentence

This message is automatically generated by a bot.

[gsmet]

@geoand I'll let you decide if this needs to be backported.

[geoand]

I'll need to look at this closer, because I think there is more to it than this...

[geoand]

@Sgitario can you explain this change please?

[Sgitario]

@Sgitario can you explain this change please?

In this line, a new instance of the outer class was being created to invoke the "before" methods (beforeEach for example). The right instance of the outer class was the one created at

quarkus/test-framework/junit5/src/main/java/io/quarkus/test/junit/QuarkusTestExtension.java

Line 766 in b08a00e

outerInstance = runningQuarkusApplication.instance(outerClass);

.

Therefore, after using the right outer instance, when running the test, the instance will contain the data set at the beforeEach method.

[geoand]

Okay, thanks

[geoand]

Please also see the bot's comment about the title

[Sgitario]

Please also see the bot's comment about the title

Yes, I renamed the PR title just after I saw the comment.

[geoand]

Actually, the title is not correct. We don't prefix the titles with the area the fix affects

[famod]

CI results looked very weird, so I rebased this to get a fresh run.

Edit: CI is still wonky.