-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Stork configuration under the quarkus namespace #24184
Support Stork configuration under the quarkus namespace #24184
Conversation
extensions/smallrye-stork/runtime/src/main/java/io/quarkus/stork/StorkConfiguration.java
Outdated
Show resolved
Hide resolved
8e41b5c
to
deb13e9
Compare
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building deb13e9
Failures⚙️ Initial JDK 11 Build #- Failing: extensions/smallrye-stork/deployment
! Skipped: docs extensions/grpc/deployment extensions/oidc-client-reactive-filter/deployment and 29 more 📦 extensions/smallrye-stork/deployment✖ |
extensions/smallrye-stork/runtime/src/main/java/io/quarkus/stork/StorkConfigProvider.java
Outdated
Show resolved
Hide resolved
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building ca67c03
Failures⚙️ Initial JDK 11 Build #- Failing: extensions/smallrye-stork/deployment
! Skipped: docs extensions/grpc/deployment extensions/oidc-client-reactive-filter/deployment and 29 more 📦 extensions/smallrye-stork/deployment✖ |
...mallrye-stork/runtime/src/main/java/io/quarkus/stork/StorkServiceDiscoveryConfiguration.java
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 7b7193b
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 11 #- Failing: extensions/resteasy-reactive/rest-client-reactive/deployment integration-tests/grpc-mutual-auth integration-tests/grpc-plain-text-mutiny and 1 more
! Skipped: extensions/oidc-client-reactive-filter/deployment extensions/oidc-token-propagation-reactive/deployment extensions/resteasy-reactive/rest-client-reactive-jackson/deployment and 11 more 📦 extensions/resteasy-reactive/rest-client-reactive/deployment✖
✖
✖
✖
📦 integration-tests/grpc-mutual-auth✖
✖
📦 integration-tests/grpc-plain-text-mutiny✖
✖
✖
✖
✖
📦 integration-tests/grpc-stork-response-time✖
✖
⚙️ JVM Tests - JDK 11 Windows #- Failing: extensions/resteasy-reactive/rest-client-reactive/deployment integration-tests/grpc-mutual-auth integration-tests/grpc-plain-text-mutiny and 1 more
! Skipped: extensions/oidc-client-reactive-filter/deployment extensions/oidc-token-propagation-reactive/deployment extensions/resteasy-reactive/rest-client-reactive-jackson/deployment and 11 more 📦 extensions/resteasy-reactive/rest-client-reactive/deployment✖
✖
✖
✖
📦 integration-tests/grpc-mutual-auth✖
✖
📦 integration-tests/grpc-plain-text-mutiny✖
✖
✖
✖
✖
📦 integration-tests/grpc-stork-response-time✖
✖
⚙️ JVM Tests - JDK 17 #- Failing: extensions/resteasy-reactive/rest-client-reactive/deployment integration-tests/grpc-mutual-auth integration-tests/grpc-plain-text-mutiny and 1 more
! Skipped: extensions/oidc-client-reactive-filter/deployment extensions/oidc-token-propagation-reactive/deployment extensions/resteasy-reactive/rest-client-reactive-jackson/deployment and 11 more 📦 extensions/resteasy-reactive/rest-client-reactive/deployment✖
✖
✖
✖
📦 integration-tests/grpc-mutual-auth✖
✖
📦 integration-tests/grpc-plain-text-mutiny✖
✖
✖
✖
✖
📦 integration-tests/grpc-stork-response-time✖
✖
⚙️ Native Tests - HTTP #- Failing: integration-tests/rest-client-reactive integration-tests/rest-client-reactive-multipart integration-tests/rest-client-reactive-stork and 1 more
📦 integration-tests/rest-client-reactive✖
📦 integration-tests/rest-client-reactive-multipart✖
📦 integration-tests/rest-client-reactive-stork✖
📦 integration-tests/resteasy-reactive-kotlin/standard✖
⚙️ Native Tests - Misc1 #- Failing: integration-tests/rest-client-reactive-kotlin-serialization
📦 integration-tests/rest-client-reactive-kotlin-serialization✖
⚙️ Native Tests - Misc4 #- Failing: integration-tests/micrometer-prometheus
📦 integration-tests/micrometer-prometheus✖
⚙️ Native Tests - Security2 #- Failing: integration-tests/oidc-client-reactive
📦 integration-tests/oidc-client-reactive✖
⚙️ Native Tests - gRPC #- Failing: integration-tests/grpc-interceptors integration-tests/grpc-mutual-auth integration-tests/grpc-plain-text-gzip and 3 more
📦 integration-tests/grpc-interceptors✖
📦 integration-tests/grpc-mutual-auth✖
📦 integration-tests/grpc-plain-text-gzip✖
📦 integration-tests/grpc-plain-text-mutiny✖
📦 integration-tests/grpc-proto-v2✖
📦 integration-tests/grpc-tls✖
|
7b7193b
to
8e1b5a5
Compare
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 8e1b5a5
|
8e1b5a5
to
544a551
Compare
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 544a551
|
cbe6e47
to
e64ac13
Compare
This comment has been minimized.
This comment has been minimized.
e64ac13
to
490d662
Compare
490d662
to
75bc6f8
Compare
@gsmet, look what we have here, Stork config under Quarkus namespace :) @aureamunoz please add info about it to the migration guide |
@aureamunoz @michalszynkiewicz the old config( |
[1] quarkusio/quarkus#24184 NB: Changes in OCP tests were not tested, see @DisabledOnQuarkusVersion annotation for explanation
[1] quarkusio/quarkus#24184 NB: Changes in OCP tests were not tested, see @DisabledOnQuarkusVersion annotation for explanation
Yes, exactly. The old style is not supported from Quarkus 2.8 |
[1] quarkusio/quarkus#24184 NB: Changes in OCP tests were not tested, see @DisabledOnQuarkusVersion annotation for explanation
Fixes #23942
This allows align the stork extension config with the others. With this PR the config should be something like: