Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE when configuration resource does not exist #24209

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

gastaldi
Copy link
Contributor

@gastaldi gastaldi commented Mar 9, 2022

This prevents an NPE to be thrown in tests if a configuration file does not exist

This prevents an NPE to be thrown in tests if a configuration file does not exist
@geoand
Copy link
Contributor

geoand commented Mar 9, 2022

Seems reasonable, but how does this happen?

I mean what test did you run that triggered the NPE?

@gastaldi
Copy link
Contributor Author

gastaldi commented Mar 9, 2022

@geoand I mistyped the filename in this snippet:

    @RegisterExtension
    static final QuarkusUnitTest config = new QuarkusUnitTest()
            .setAllowTestClassOutsideDeployment(true)
            .withConfigurationResource("blah.properties");

@geoand
Copy link
Contributor

geoand commented Mar 9, 2022

Underwood, thanks

@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 9, 2022
@gastaldi gastaldi merged commit 86339f1 into quarkusio:main Mar 9, 2022
@gastaldi gastaldi deleted the npe branch March 9, 2022 21:14
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Mar 9, 2022
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Mar 9, 2022
@gsmet gsmet modified the milestones: 2.8 - main, 2.7.5.Final Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants