Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add misfireThreshold default to QuartzRuntimeConfig.java #24253

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

VanillaSpoon
Copy link
Contributor

@VanillaSpoon VanillaSpoon commented Mar 10, 2022

Add misfireThreshold default to QuartzRuntimeConfig.java

This enables the misfireThreshold configuration to be overridden by the user.

Fixes #24105.

@quarkus-bot
Copy link

quarkus-bot bot commented Mar 10, 2022

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building de6d0ab

Status Name Step Failures Logs Raw logs
Initial JDK 11 Build Build Failures Logs Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: extensions/quartz/runtime 
! Skipped: devtools/bom-descriptor-json docs extensions/quartz/deployment and 2 more

📦 extensions/quartz/runtime

Failed to execute goal net.revelc.code.formatter:formatter-maven-plugin:2.18.0:validate (default) on project quarkus-quartz: File '/home/runner/work/quarkus/quarkus/extensions/quartz/runtime/src/main/java/io/quarkus/quartz/runtime/QuartzScheduler.java' has not been previously formatted. Please format file (for example by invoking `mvn -f extensions/quartz/runtime net.revelc.code.formatter:formatter-maven-plugin:2.18.0:format`) and commit before running validation!

Copy link
Member

@machi1990 machi1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @VanillaSpoon

See the suggestion about making the property a Duration type and the modified comment on top of it.

@machi1990
Copy link
Member

Failing Jobs - Building de6d0ab

Status Name Step Failures Logs Raw logs
Initial JDK 11 Build Build Failures Logs Raw logs

Failures

Initial JDK 11 Build #

- Failing: extensions/quartz/runtime 
! Skipped: devtools/bom-descriptor-json docs extensions/quartz/deployment and 2 more

extensions/quartz/runtime

heavy_multiplication_x Failed to execute goal net.revelc.code.formatter:formatter-maven-plugin:2.18.0:validate (default) on project quarkus-quartz: File '/home/runner/work/quarkus/quarkus/extensions/quartz/runtime/src/main/java/io/quarkus/quartz/runtime/QuartzScheduler.java' has not been previously formatted. Please format file (for example by invoking `mvn -f extensions/quartz/runtime net.revelc.code.formatter:formatter-maven-plugin:2.18.0:format`) and commit before running validation!

@VanillaSpoon CI is failing because of a formatting problem. Please see https://github.com/quarkusio/quarkus/blob/main/CONTRIBUTING.md#ide-config-and-code-style or https://github.com/quarkusio/quarkus/blob/main/CONTRIBUTING.md#formatting on how to properly setup your IDE for auto formatting or the command to run to fix the format issue

@VanillaSpoon
Copy link
Contributor Author

Thanks @machi1990, I'll get back to you :)

@quarkus-bot
Copy link

quarkus-bot bot commented Mar 10, 2022

This workflow status is outdated as a new workflow run has been triggered.

Failing Jobs - Building 1467d4c

Status Name Step Failures Logs Raw logs
Initial JDK 11 Build Build Failures Logs Raw logs

Failures

⚙️ Initial JDK 11 Build #

- Failing: extensions/quartz/runtime 
! Skipped: devtools/bom-descriptor-json docs extensions/quartz/deployment and 2 more

📦 extensions/quartz/runtime

Failed to execute goal net.revelc.code.formatter:formatter-maven-plugin:2.18.0:validate (default) on project quarkus-quartz: File '/home/runner/work/quarkus/quarkus/extensions/quartz/runtime/src/main/java/io/quarkus/quartz/runtime/QuartzScheduler.java' has not been previously formatted. Please format file (for example by invoking `mvn -f extensions/quartz/runtime net.revelc.code.formatter:formatter-maven-plugin:2.18.0:format`) and commit before running validation!

@geoand
Copy link
Contributor

geoand commented Mar 11, 2022

@VanillaSpoon thanks for this.

See the bot's message for the exact command you need to run into order to format the file.

@machi1990 machi1990 merged commit bf3cca2 into quarkusio:main Mar 11, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Mar 11, 2022
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quartz configuration misfireThreshold in application.properties file
3 participants