-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add misfireThreshold default to QuartzRuntimeConfig.java #24253
Conversation
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building de6d0ab
Failures⚙️ Initial JDK 11 Build #- Failing: extensions/quartz/runtime
! Skipped: devtools/bom-descriptor-json docs extensions/quartz/deployment and 2 more 📦 extensions/quartz/runtime✖ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @VanillaSpoon
See the suggestion about making the property a Duration
type and the modified comment on top of it.
extensions/quartz/runtime/src/main/java/io/quarkus/quartz/runtime/QuartzRuntimeConfig.java
Outdated
Show resolved
Hide resolved
extensions/quartz/runtime/src/main/java/io/quarkus/quartz/runtime/QuartzScheduler.java
Outdated
Show resolved
Hide resolved
@VanillaSpoon CI is failing because of a formatting problem. Please see https://github.com/quarkusio/quarkus/blob/main/CONTRIBUTING.md#ide-config-and-code-style or https://github.com/quarkusio/quarkus/blob/main/CONTRIBUTING.md#formatting on how to properly setup your IDE for auto formatting or the command to run to fix the format issue |
de6d0ab
to
1467d4c
Compare
extensions/quartz/runtime/src/main/java/io/quarkus/quartz/runtime/QuartzRuntimeConfig.java
Show resolved
Hide resolved
Thanks @machi1990, I'll get back to you :) |
This workflow status is outdated as a new workflow run has been triggered. Failing Jobs - Building 1467d4c
Failures⚙️ Initial JDK 11 Build #- Failing: extensions/quartz/runtime
! Skipped: devtools/bom-descriptor-json docs extensions/quartz/deployment and 2 more 📦 extensions/quartz/runtime✖ |
@VanillaSpoon thanks for this. See the bot's message for the exact command you need to run into order to format the file. |
1467d4c
to
4a193bf
Compare
4a193bf
to
8a292db
Compare
Add misfireThreshold default to QuartzRuntimeConfig.java
This enables the misfireThreshold configuration to be overridden by the user.
Fixes #24105.