Remove @Override annotations from to-be-removed API methods and replace BM#fireEvent calls #24271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manovotn
commented
Mar 11, 2022
| @@ -115,7 +115,7 @@ public void validate(InjectionPoint injectionPoint) { | |||
| throw new UnsupportedOperationException(); | |||
| } | |||
|
|
|||
| @Override | |||
| // Deprecated method which can be safely removed once we use CDI 4.0+ | |||
There was a problem hiding this comment.
I'd actually love to perform some logging here stating you should use a different approach but I am sort of expecting complaints from users seeing an info/warn messages all of sudden so I didn't do it yet.
mkouba
reviewed
Mar 11, 2022
.../tests/src/test/java/io/quarkus/arc/test/buildextension/observers/SyntheticObserverTest.java
Outdated
Show resolved
Hide resolved
mkouba
reviewed
Mar 11, 2022
independent-projects/arc/runtime/src/main/java/io/quarkus/arc/InjectableBean.java
Show resolved
Hide resolved
manovotn
force-pushed
the
removeCdiDeprecatedCalls
branch
from
88daeaf to
7cdc30d
Compare
Replace BM#fireEvent calls.
manovotn
force-pushed
the
removeCdiDeprecatedCalls
branch
from
7cdc30d to
89e383a
Compare
mkouba
approved these changes
Mar 11, 2022
mkouba
added
the
triage/waiting-for-ci
quarkus-bot
bot
removed
the
triage/waiting-for-ci
|
FYI, related change by Brian in Hibernate ORM: This is included in Quarkus via #24362 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will ease future transition to CDI 4 API. I didn't find any other occurrences of deprecated CDI APIs in Quarkus as such. That being said, external libs may still have them but that's not necessarily for us to fix.
For completeness, the removed methods in CDI 4 can be seen here - jakartaee/cdi#472
Most of them are not an issue for Quarkus as they are related to portable extensions in some way.