Ensure that connection issues can be handled in Reactive REST Client #24368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalszynkiewicz
approved these changes
Mar 17, 2022
geoand
added
the
triage/waiting-for-ci
This comment has been minimized.
This comment has been minimized.
gastaldi
reviewed
Mar 18, 2022
| @@ -247,6 +248,10 @@ public void handle(Throwable failure) { | |||
| }, new Consumer<>() { | |||
| @Override | |||
| public void accept(Throwable event) { | |||
| // set some properties to prevent NPEs down the chain | |||
| requestContext.setResponseHeaders(new MultivaluedTreeMap<>()); | |||
There was a problem hiding this comment.
Is this always the first handler invoked? Curious if the response headers could be overwritten if they were set previously
There was a problem hiding this comment.
It doesn't really matter if it gets overridden. All that matters in this case is that it's not null
quarkus-bot
bot
added
kind/bugfix
and removed
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #24364