Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to configure Quartz misfire handling strategy #24382

Merged
merged 2 commits into from
Mar 20, 2022
Merged

Allow to configure Quartz misfire handling strategy #24382

merged 2 commits into from
Mar 20, 2022

Conversation

rmanibus
Copy link
Contributor

fix #24254

@rmanibus
Copy link
Contributor Author

cc @machi1990

@rmanibus rmanibus force-pushed the fix_24254 branch 2 times, most recently from 222682f to 12c0aa1 Compare March 17, 2022 19:23
@quarkus-bot

This comment has been minimized.

Sign in to view
machi1990
machi1990 requested changes Mar 18, 2022
View reviewed changes
Copy link
Member

@machi1990 machi1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great work.
Thank you.
I've left some comments, very minor and mostly around renaming.
Would you also mind a section in the docs? Thank you.

@rmanibus
Copy link
Contributor Author

This is great work.
Thank you.
I've left some comments, very minor and mostly around renaming.
Would you also mind a section in the docs? Thank you.

@machi1990 I made the changes and added some doc.

@rmanibus rmanibus force-pushed the fix_24254 branch 2 times, most recently from 1ea9ead to 71a72f9 Compare March 18, 2022 13:33
machi1990
machi1990 approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@machi1990 machi1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Thanks for the awesome work @rmanibus

@quarkus-bot

This comment has been minimized.

Sign in to view
@quarkus-bot

This comment has been minimized.

Sign in to view
@machi1990 machi1990 requested a review from mkouba March 18, 2022 18:19
gsmet
gsmet requested changes Mar 18, 2022
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't merge already, I will make minor adjustments to the exception messages tomorrow.

@gsmet gsmet self-assigned this Mar 18, 2022
rmanibus and others added 2 commits March 19, 2022 14:07
@rmanibus @gsmet
Allow to configure Quartz misfire handling strategy
d517d62
@gsmet
Quartz misfire policy - Better error messages
c31f8bc 
Two changes here:
- always handle of the cases in the enum so that we get proper warnings
  if a value is not taken into account
- use the actual values that we document as valid values in the error
  messages
gsmet
gsmet approved these changes Mar 19, 2022
View reviewed changes
Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmanibus I added an additional commit for you to look at.

@gsmet gsmet merged commit 05c1092 into quarkusio:main Mar 20, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Mar 20, 2022
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Mar 20, 2022
@gsmet
Copy link
Member

gsmet commented Mar 20, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machi1990 machi1990 machi1990 approved these changes

@gsmet gsmet gsmet approved these changes

@mkouba mkouba Awaiting requested review from mkouba

Assignees

@gsmet gsmet

Labels
area/documentation area/scheduler kind/enhancement New feature or request
Projects
None yet
Milestone
2.8.0.CR1
Development

Successfully merging this pull request may close these issues.

Allow to configure Quartz misfire handling strategy globally that will be applied to all @Scheduled methods
4 participants
@rmanibus @gsmet @mkouba @machi1990