Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RESTEasy Reactive the default codestart #24413

Merged
merged 4 commits into from
Mar 19, 2022

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Mar 18, 2022

Also only add the default codestart if no extensions have been selected.
Quarkus is more than a REST framework and this behavior is annoying for
anything that is not REST and does not have a codestart.

Fix #24175

@gsmet gsmet requested a review from geoand March 18, 2022 15:34
@quarkus-bot quarkus-bot bot added area/cli Related to quarkus cli (not maven/gradle/etc.) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/platform Issues related to definition and interaction with Quarkus Platform labels Mar 18, 2022
@gsmet gsmet force-pushed the resteasy-by-default branch from 0d0b0b5 to 2da75de Compare March 18, 2022 18:20
@quarkus-bot

This comment has been minimized.

@gsmet gsmet force-pushed the resteasy-by-default branch from 2da75de to 2a08a7e Compare March 18, 2022 23:22
@quarkus-bot

This comment has been minimized.

@gsmet gsmet force-pushed the resteasy-by-default branch from 2a08a7e to 0998cac Compare March 19, 2022 11:11
@quarkus-bot

This comment has been minimized.

gsmet added 4 commits March 19, 2022 17:25
Also only add the default codestart if no extensions have been selected.
Quarkus is more than a REST framework and this behavior is annoying for
anything that is not REST and does not have a codestart.
@gsmet gsmet force-pushed the resteasy-by-default branch from 0998cac to d6d2ed4 Compare March 19, 2022 16:31
@quarkus-bot quarkus-bot bot added area/jbang Issues related to when using jbang.dev with Quarkus area/rest labels Mar 19, 2022
@quarkus-bot
Copy link

quarkus-bot bot commented Mar 19, 2022

Failing Jobs - Building d6d2ed4

Status Name Step Failures Logs Raw logs
JVM Tests - JDK 11 Build Failures Logs Raw logs
✔️ JVM Tests - JDK 17

Full information is available in the Build summary check run.

Failures

⚙️ JVM Tests - JDK 11 #

- Failing: integration-tests/grpc-hibernate-reactive 

📦 integration-tests/grpc-hibernate-reactive

com.example.reactive.ReactiveServiceTest.shouldWatchAndAddMultipleTimes - More details - Source on GitHub

java.lang.RuntimeException: java.lang.RuntimeException: Failed to start quarkus
	at io.quarkus.test.junit.QuarkusTestExtension.throwBootFailureException(QuarkusTestExtension.java:632)
	at io.quarkus.test.junit.QuarkusTestExtension.interceptTestClassConstructor(QuarkusTestExtension.java:703)

@gsmet gsmet merged commit 7954cb1 into quarkusio:main Mar 19, 2022
@quarkus-bot quarkus-bot bot added this to the 2.8 - main milestone Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins area/jbang Issues related to when using jbang.dev with Quarkus area/maven area/platform Issues related to definition and interaction with Quarkus Platform area/rest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not add RESTEasy classic by default in generated projects
2 participants