Do not run NativeImageBuildContainerRunnerTest test unless -Dtest-containers is set #25170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoand
reviewed
Apr 26, 2022
...yment/src/test/java/io/quarkus/deployment/pkg/steps/NativeImageBuildContainerRunnerTest.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
holly-cummins
force-pushed
the
core-deployment-startcontainers-guard
branch
from
d2081aa to
62ae356
Compare
|
Updated and squashed. I've tested locally and confirmed the behaviour is still the same (with no podman, fail in IDE, fail with |
famod
reviewed
Apr 26, 2022
This comment has been minimized.
This comment has been minimized.
quarkus-bot
bot
added
area/cli
holly-cummins
force-pushed
the
core-deployment-startcontainers-guard
branch
from
9df2fed to
0763d8c
Compare
holly-cummins
force-pushed
the
core-deployment-startcontainers-guard
branch
from
0763d8c to
7a466f5
Compare
geoand
removed
area/documentation
area/core
area/security
area/logging
area/vertx
area/dependencies
geoand
added
area/testing
triage/waiting-for-ci
|
Updated and squashed. (I'm a bit troubled by the vertx CI failures in the earlier build on this PR, but it seems like they have to be unrelated to these changes.) |
Failing Jobs - Building 7a466f5
Full information is available in the Build summary check run. Failures⚙️ JVM Tests - JDK 17 #- Failing: integration-tests/container-image/maven-invoker-way
📦 integration-tests/container-image/maven-invoker-way✖ 📦 integration-tests/container-image/maven-invoker-way/target/it/container-build-with-keycloak-default-realm✖ ✖ |
quarkus-bot
bot
added
kind/bugfix
and removed
triage/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25108.
This is a slightly more elaborate fix than I did for #25141. Only one test in the
core/deploymentmodule needs containers, so I didn't want to disable the whole module unlessstart-containerswas set. I could have just let the test read thestart-containerssystem property, but that would result in it being disabled by default if run within an IDE. I figure if you're running a test within an IDE you want it to run, without any extra configuration, so I inverted the properties in the pom so the test is disabled by default when run in maven, but enabled by default when run 'loose'.With the changes, on a docker/podman-free system,
./mvnw -Dquickly -DskipTests=false -Dstart-containers -f core/deploymentruns the test and gives a failure./mvnw -Dquickly -DskipTests=false -f core/deploymentruns all the other tests in the module, and runs clean