Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knative: fix clusterLocal property #25220

Merged
merged 1 commit into from
May 10, 2022
Merged

Knative: fix clusterLocal property #25220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...etes/vanilla/deployment/src/main/java/io/quarkus/kubernetes/deployment/KnativeConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,6 +388,7 @@ public EnvVarsConfig getEnv() {
/**
* Whether or not this service is cluster-local.
* Cluster local services are not exposed to the outside world.
* More information in <a href="https://knative.dev/docs/serving/services/private-services/">this link</a>.
*/
@ConfigItem
public boolean clusterLocal;
Expand Down
2 changes: 1 addition & 1 deletion ...s/vanilla/deployment/src/main/java/io/quarkus/kubernetes/deployment/KnativeProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ public List<DecoratorBuildItem> createDecorators(ApplicationInfoBuildItem applic

if (config.clusterLocal) {
result.add(new DecoratorBuildItem(KNATIVE,
new AddLabelDecorator(name, "serving.knative.dev/visibility", "cluster-local")));
new AddLabelDecorator(name, "networking.knative.dev/visibility", "cluster-local")));
}

/**
Expand Down
2 changes: 1 addition & 1 deletion .../quarkus-standard-way/src/test/java/io/quarkus/it/kubernetes/KnativeClusterLocalTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ public void assertGeneratedResources() throws IOException {

assertThat(getKNativeService(kubernetesDir)).satisfies(service -> {
assertThat(service.getMetadata()).satisfies(m -> {
assertThat(m.getLabels()).contains(entry("serving.knative.dev/visibility", "cluster-local"));
assertThat(m.getLabels()).contains(entry("networking.knative.dev/visibility", "cluster-local"));
});
});
}
Expand Down